Message ID | 001801ce0b41$e2a53260$a7ef9720$%han@samsung.com |
---|---|
State | Superseded |
Headers | show
Return-Path: <rtc-linux+bncBDTJ5LFEQQCBBNM666EAKGQE772SAXY@googlegroups.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-vb0-f64.google.com (mail-vb0-f64.google.com [209.85.212.64]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id E4EB52C0085 for <incoming@patchwork.ozlabs.org>; Fri, 15 Feb 2013 17:01:28 +1100 (EST) Received: by mail-vb0-f64.google.com with SMTP id ff1sf1047162vbb.9 for <incoming@patchwork.ozlabs.org>; Thu, 14 Feb 2013 22:01:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=UKY96lQpNfX4GCb8Sbsz4ksTn2FXdAeJ/mNoT5uIWDI=; b=lDYSsuOq9V38ZUv2lnpDX+ADPMo/c/ZHoGioGHwH0v4WkjmLBL7DnzMP97PAnGuS9U a6X7u5Moh7KEyo2HGj7D6WHJkOsRmSAO0C9bEk2jeLZGQ6gvDlAIz37ARqU//Jg6nZGK C7UsBtwse1fmQP+yoqZxvXq41P1ykNuetm+QSKLhWbhxVZ+287tc/YEEDv2vesZXwcI5 QDcadcfR6j+7K1iV/UszB9tPdmH0rOY/3NyjprHlIG66R7Az6q4BIYX8hq8F9ihDzWD+ oRTBUehQE0YM15dZ0VZBmWeGlEdbuD5nSUh9Fb99XMK5q5y6gaplKoj8Ejpotw7TgcTw nDJg== X-Received: by 10.50.161.233 with SMTP id xv9mr166205igb.15.1360908085902; Thu, 14 Feb 2013 22:01:25 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.42.229 with SMTP id r5ls165071igl.27.canary; Thu, 14 Feb 2013 22:01:25 -0800 (PST) X-Received: by 10.66.86.166 with SMTP id q6mr901527paz.44.1360908085554; Thu, 14 Feb 2013 22:01:25 -0800 (PST) X-Received: by 10.66.86.166 with SMTP id q6mr901526paz.44.1360908085542; Thu, 14 Feb 2013 22:01:25 -0800 (PST) Received: from mailout4.samsung.com (mailout4.samsung.com. [203.254.224.34]) by gmr-mx.google.com with ESMTP id n8si11647250paz.2.2013.02.14.22.01.25; Thu, 14 Feb 2013 22:01:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) client-ip=203.254.224.34; Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MI800JYPZEC1R40@mailout4.samsung.com> for rtc-linux@googlegroups.com; Fri, 15 Feb 2013 15:01:24 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.49]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id 4F.12.06692.43FCD115; Fri, 15 Feb 2013 15:01:24 +0900 (KST) X-AuditID: cbfee691-b7f556d000001a24-f9-511dcf348e71 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id A5.4F.03880.43FCD115; Fri, 15 Feb 2013 15:01:24 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MI8007C0ZECCBV0@mmp1.samsung.com> for rtc-linux@googlegroups.com; Fri, 15 Feb 2013 15:01:24 +0900 (KST) From: Jingoo Han <jg1.han@samsung.com> To: 'Andrew Morton' <akpm@linux-foundation.org> Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' <a.zummo@towertech.it>, rtc-linux@googlegroups.com, 'Jingoo Han' <jg1.han@samsung.com> References: <001201ce0b41$4900c4d0$db024e70$%han@samsung.com> In-reply-to: <001201ce0b41$4900c4d0$db024e70$%han@samsung.com> Subject: [rtc-linux] [PATCH 07/11] rtc: rtc-rs5c313: use pr_err() instead of printk() Date: Fri, 15 Feb 2013 15:01:24 +0900 Message-id: <001801ce0b41$e2a53260$a7ef9720$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4LQUiQnZ5yIGDDRaO8BQe4Zm4AfgAAIGmw X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrAIsWRmVeSWpSXmKPExsVy+t8zQ12T87KBBusbVCz2d3YwOjB67Jl4 ki2AMYrLJiU1J7MstUjfLoErY8uCpywFTRwV/xvvMjUwHmDrYuTkkBAwkVg67Q4jhC0mceHe eqA4F4eQwDJGifXz17PAFO3YtwEqsYhRYvL7PiYIZyaTxJ2PC8Cq2ATUJL58OczexcjBISKg L9HWogFSwyzQyyhxpnc3O0iNkICtxIRP65hBbE4BO4nvfx6ygdQLC3hK7L7pBBJmEVCVOP3l BVgJL1D5+V8boWxBiR+T74GtYhbQkti8rYkVwpaX2LzmLTPIGAkBdYlHf3VBwiICRhLfWj4x Q5SISOx78Y4R5BwJgWXsEpe6vzJB7BKQ+Db5EAtEr6zEpgPMEP9KShxccYNlAqPELCSbZyHZ PAvJ5llIVixgZFnFKJpakFxQnJReZKpXnJhbXJqXrpecn7uJERJbE3cw3j9gfYgxGWj9RGYp 0eR8YGzmlcQbGhubmJmYmphbmpqbkiasJM4rf0kmUEggPbEkNTs1tSC1KL6oNCe1+BAjEwen VAOjg46+YLBc7vZnAt1Cy49szOVjLpVpmuRjIG6W8LLYJIb77P8N+xa5tW+1FS56eClKc8+U tzoR0pLft09Of20iXxbb8n2imORMg6Dv/wvXP9rAmvpvQ+GFl86sie0v/02/su/NrLXxvaFv XqtauuTpMoh9e/69sN7k3O4T72Z8DzxSO/NR34ttSizFGYmGWsxFxYkANU972sMCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplleLIzCtJLcpLzFFi42I5/e+xgK7JedlAg1cr5C32d3YwOjB67Jl4 ki2AMaqB0SYjNTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMH aKySQlliTilQKCCxuFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCOMWPLgqcsBU0cFf8b7zI1 MB5g62Lk5JAQMJHYsW8DlC0mceHeeiCbi0NIYBGjxOT3fUwQzkwmiTsfF7CAVLEJqEl8+XKY vYuRg0NEQF+irUUDpIZZoJdR4kzvbnaQGiEBW4kJn9Yxg9icAnYS3/88ZAOpFxbwlNh90wkk zCKgKnH6ywuwEl6g8vO/NkLZghI/Jt8DW8UsoCWxeVsTK4QtL7F5zVtmkDESAuoSj/7qgoRF BIwkvrV8YoYoEZHY9+Id4wRGoVlIJs1CMmkWkkmzkLQsYGRZxSiaWpBcUJyUnmukV5yYW1ya l66XnJ+7iREcuc+kdzCuarA4xCjAwajEwysgIRsoxJpYVlyZe4hRgoNZSYR3TQhQiDclsbIq tSg/vqg0J7X4EGMy0KMTmaVEk/OBSSWvJN7Q2MTMyNLIzMLIxNycNGElcV7GU08ChATSE0tS s1NTC1KLYLYwcXBKNTB2Hz79Ni58retWneflT7tbZ7/Y+ot/7+mNckefTrtssS9fenPuwkn6 hlL8waKrIiYEK+61Plg+lzk+8li7YHrFOcGVaSdLIt73/r81qXqH59FNOxjLT95bVPn77JQq +6YTazd0f9XO0BJ+ceCY5oWjLQymFSevSAdylsx2Kdeq/aDiZH227GmXEktxRqKhFnNRcSIA l48FVyADAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: <rtc-linux.googlegroups.com> X-Google-Group-Id: 712029733259 List-Post: <http://groups.google.com/group/rtc-linux/post?hl=en_US>, <mailto:rtc-linux@googlegroups.com> List-Help: <http://groups.google.com/support/?hl=en_US>, <mailto:rtc-linux+help@googlegroups.com> List-Archive: <http://groups.google.com/group/rtc-linux?hl=en_US> Sender: rtc-linux@googlegroups.com List-Subscribe: <http://groups.google.com/group/rtc-linux/subscribe?hl=en_US>, <mailto:rtc-linux+subscribe@googlegroups.com> List-Unsubscribe: <http://groups.google.com/group/rtc-linux/subscribe?hl=en_US>, <mailto:googlegroups-manage+712029733259+unsubscribe@googlegroups.com> Content-type: text/plain; charset=ISO-8859-1 Content-language: ko |
diff --git a/drivers/rtc/rtc-rs5c313.c b/drivers/rtc/rtc-rs5c313.c index d1aee79..8ca55a6 100644 --- a/drivers/rtc/rtc-rs5c313.c +++ b/drivers/rtc/rtc-rs5c313.c @@ -39,6 +39,8 @@ * 1.13 Nobuhiro Iwamatsu: Updata driver. */ +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + #include <linux/module.h> #include <linux/err.h> #include <linux/rtc.h> @@ -352,8 +354,7 @@ static void rs5c313_check_xstp_bit(void) tm.tm_year = 2000 - 1900; rs5c313_rtc_set_time(NULL, &tm); - printk(KERN_ERR "RICHO RS5C313: invalid value, resetting to " - "1 Jan 2000\n"); + pr_err("RICHO RS5C313: invalid value, resetting to 1 Jan 2000\n"); } RS5C313_CEDISABLE; ndelay(700); /* CE:L */
Fixed the checkpatch warning as below: WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- drivers/rtc/rtc-rs5c313.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)