From patchwork Fri Feb 15 06:00:41 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 220640 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-vb0-f62.google.com (mail-vb0-f62.google.com [209.85.212.62]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 13B6E2C0082 for ; Fri, 15 Feb 2013 17:00:46 +1100 (EST) Received: by mail-vb0-f62.google.com with SMTP id k17sf1015113vbj.17 for ; Thu, 14 Feb 2013 22:00:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=iP4Sg3eaHLpO9K72EbI4wRWRBY4EJxQjDOYOGuuYYV0=; b=FwiIjMvABh49yzpLNAVXgh7I6n01SdLBUCb9W8MRnWF+xTaKBUR2kSnDQrlKMem/m6 uKRcdHI84OftbEmkpuBhXySFVhY4NiRw/DboZ9FxDKUOlhWWqmWY3zjHdjsuNABP2ITC 9/9JDLTIxuqXy0IwfpOyMs1t/wazzQkHn+wQ4L2OBftNnIzW4o+ytGYDHjMfRsXXqiMb pcK7wfm61XIsaqpvjqPwvf8IMOTZ/55rfoA3wty7seBI/Rsthh6G+jAdTHdIkvslieHz EMQylddWOheQLzPaHhlSjlAtCT4q9RdnMLIBbMKIDJ/FLW7+yc/5vKFliwHEJh6ppk5K w04g== X-Received: by 10.50.188.231 with SMTP id gd7mr171392igc.9.1360908043599; Thu, 14 Feb 2013 22:00:43 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.207.68 with SMTP id lu4ls309215igc.44.gmail; Thu, 14 Feb 2013 22:00:43 -0800 (PST) X-Received: by 10.68.196.229 with SMTP id ip5mr176312pbc.6.1360908042875; Thu, 14 Feb 2013 22:00:42 -0800 (PST) X-Received: by 10.68.196.229 with SMTP id ip5mr176311pbc.6.1360908042864; Thu, 14 Feb 2013 22:00:42 -0800 (PST) Received: from mailout4.samsung.com (mailout4.samsung.com. [203.254.224.34]) by gmr-mx.google.com with ESMTP id d9si62320paw.0.2013.02.14.22.00.42; Thu, 14 Feb 2013 22:00:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) client-ip=203.254.224.34; Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MI800NTKZAR4DG0@mailout4.samsung.com> for rtc-linux@googlegroups.com; Fri, 15 Feb 2013 15:00:41 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.48]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id 0A.DE.03448.90FCD115; Fri, 15 Feb 2013 15:00:41 +0900 (KST) X-AuditID: cbfee68f-b7f656d000000d78-34-511dcf090c7d Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 96.0F.03880.90FCD115; Fri, 15 Feb 2013 15:00:41 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MI80074FZD5CBV0@mmp1.samsung.com> for rtc-linux@googlegroups.com; Fri, 15 Feb 2013 15:00:41 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <001201ce0b41$4900c4d0$db024e70$%han@samsung.com> In-reply-to: <001201ce0b41$4900c4d0$db024e70$%han@samsung.com> Subject: [rtc-linux] [PATCH 06/11] rtc: rtc-at91rm9200: use dev_dbg()/dev_err() instead of printk()/pr_debug() Date: Fri, 15 Feb 2013 15:00:41 +0900 Message-id: <001701ce0b41$c9372fe0$5ba58fa0$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4LQUiQnZ5yIGDDRaO8BQe4Zm4AfgAAGtCg X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrAIsWRmVeSWpSXmKPExsVy+t8zA13O87KBBgdfW1js7+xgdGD02DPx JFsAYxSXTUpqTmZZapG+XQJXxrGTfewFlyQrTn5ayNTAuFS0i5GTQ0LAROLmvo1sELaYxIV7 64FsLg4hgWWMEgemX2aCKZrc8ogJIrGIUWJv5yF2CGcmk8S0A80sIFVsAmoSX74cBkpwcIgI 6Eu0tWiA1DAL9DJKnOndzQ5SIyRgKzHh0zpmEJtTwE7i+5+HYKuFBVIkTna3MYH0sgioSmzr 0AUJ8wKVb/i2lRHCFpT4Mfke2CpmAS2JzduaWCFseYnNa94yg7RKCKhLPPoL1ioiYCSxbu9t qHIRiX0v3jGCnCMhsIpdYuqGr2AzWQQEJL5NPsQC0SsrsekAM8S/khIHV9xgmcAoMQvJ5llI Ns9CsnkWkhULGFlWMYqmFiQXFCelFxnrFSfmFpfmpesl5+duYoTEVv8OxrsHrA8xJgOtn8gs JZqcD4zNvJJ4Q2NjEzMTUxNzS1NzU9KElcR55S/JBAoJpCeWpGanphakFsUXleakFh9iZOLg lGpgZLWJYD68cc3Zi50Kc7TjN5Vfm57za/dTs19T2gXiZ8+bNSEj1y1P5P7E3WtjvgqxBjv3 /OY6WnLsl0qA1w6X5Z8j/7w8bpv05/ie62ufKZ8NuuXMxpi5VVYzckbGlQp9q5Kele88dcur RT0vri5Ty1uk2bflfat9mvMjyVIuhoJ3a2//794UrsRSnJFoqMVcVJwIACQ5Jb/DAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplleLIzCtJLcpLzFFi42I5/e+xgC7nedlAg3nnTSz2d3YwOjB67Jl4 ki2AMaqB0SYjNTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMH aKySQlliTilQKCCxuFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCOMePYyT72gkuSFSc/LWRq YFwq2sXIySEhYCIxueURE4QtJnHh3nq2LkYuDiGBRYwSezsPsUM4M5kkph1oZgGpYhNQk/jy 5TBQgoNDREBfoq1FA6SGWaCXUeJM7252kBohAVuJCZ/WMYPYnAJ2Et//PGQDsYUFUiROdrcx gfSyCKhKbOvQBQnzApVv+LaVEcIWlPgx+R7YKmYBLYnN25pYIWx5ic1r3jKDtEoIqEs8+gvW KiJgJLFu722ochGJfS/eMU5gFJqFZNIsJJNmIZk0C0nLAkaWVYyiqQXJBcVJ6blGesWJucWl eel6yfm5mxjBkftMegfjqgaLQ4wCHIxKPLwCErKBQqyJZcWVuYcYJTiYlUR414QAhXhTEiur Uovy44tKc1KLDzEmA/05kVlKNDkfmFTySuINjU3MjCyNzCyMTMzNSRNWEudlPPUkQEggPbEk NTs1tSC1CGYLEwenVAOj8qfX/ypWrZzzcGrk6Qvzw6ufVDcVXdzWflsi6NNaAY8zdauOrE2d /KvSrL3qTMhxNZ5lPMfTr4k8P2bxcgN/wpT8yewzq1aUPSmcH3qxXVOHe/1lhh1izzet0tDp f/anevnbjN/Sy4IEda+v/Hjr7RofNptvky+snqP85sT110kfll3QMFj8/rsSS3FGoqEWc1Fx IgDMW1TzIAMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko Fixed the checkpatch warning as below: WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... Signed-off-by: Jingoo Han --- drivers/rtc/rtc-at91rm9200.c | 17 ++++++++--------- 1 files changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c index b6469e2..4a2e451 100644 --- a/drivers/rtc/rtc-at91rm9200.c +++ b/drivers/rtc/rtc-at91rm9200.c @@ -86,7 +86,7 @@ static int at91_rtc_readtime(struct device *dev, struct rtc_time *tm) tm->tm_yday = rtc_year_days(tm->tm_mday, tm->tm_mon, tm->tm_year); tm->tm_year = tm->tm_year - 1900; - pr_debug("%s(): %4d-%02d-%02d %02d:%02d:%02d\n", __func__, + dev_dbg(dev, "%s(): %4d-%02d-%02d %02d:%02d:%02d\n", __func__, 1900 + tm->tm_year, tm->tm_mon, tm->tm_mday, tm->tm_hour, tm->tm_min, tm->tm_sec); @@ -100,7 +100,7 @@ static int at91_rtc_settime(struct device *dev, struct rtc_time *tm) { unsigned long cr; - pr_debug("%s(): %4d-%02d-%02d %02d:%02d:%02d\n", __func__, + dev_dbg(dev, "%s(): %4d-%02d-%02d %02d:%02d:%02d\n", __func__, 1900 + tm->tm_year, tm->tm_mon, tm->tm_mday, tm->tm_hour, tm->tm_min, tm->tm_sec); @@ -145,7 +145,7 @@ static int at91_rtc_readalarm(struct device *dev, struct rtc_wkalrm *alrm) alrm->enabled = (at91_rtc_read(AT91_RTC_IMR) & AT91_RTC_ALARM) ? 1 : 0; - pr_debug("%s(): %4d-%02d-%02d %02d:%02d:%02d\n", __func__, + dev_dbg(dev, "%s(): %4d-%02d-%02d %02d:%02d:%02d\n", __func__, 1900 + tm->tm_year, tm->tm_mon, tm->tm_mday, tm->tm_hour, tm->tm_min, tm->tm_sec); @@ -183,7 +183,7 @@ static int at91_rtc_setalarm(struct device *dev, struct rtc_wkalrm *alrm) at91_rtc_write(AT91_RTC_IER, AT91_RTC_ALARM); } - pr_debug("%s(): %4d-%02d-%02d %02d:%02d:%02d\n", __func__, + dev_dbg(dev, "%s(): %4d-%02d-%02d %02d:%02d:%02d\n", __func__, at91_alarm_year, tm.tm_mon, tm.tm_mday, tm.tm_hour, tm.tm_min, tm.tm_sec); @@ -192,7 +192,7 @@ static int at91_rtc_setalarm(struct device *dev, struct rtc_wkalrm *alrm) static int at91_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled) { - pr_debug("%s(): cmd=%08x\n", __func__, enabled); + dev_dbg(dev, "%s(): cmd=%08x\n", __func__, enabled); if (enabled) { at91_rtc_write(AT91_RTC_SCCR, AT91_RTC_ALARM); @@ -240,7 +240,7 @@ static irqreturn_t at91_rtc_interrupt(int irq, void *dev_id) rtc_update_irq(rtc, 1, events); - pr_debug("%s(): num=%ld, events=0x%02lx\n", __func__, + dev_dbg(&pdev->dev, "%s(): num=%ld, events=0x%02lx\n", __func__, events >> 8, events & 0x000000FF); return IRQ_HANDLED; @@ -296,8 +296,7 @@ static int __init at91_rtc_probe(struct platform_device *pdev) IRQF_SHARED, "at91_rtc", pdev); if (ret) { - printk(KERN_ERR "at91_rtc: IRQ %d already in use.\n", - irq); + dev_err(&pdev->dev, "at91_rtc: IRQ %d already in use.\n", irq); return ret; } @@ -315,7 +314,7 @@ static int __init at91_rtc_probe(struct platform_device *pdev) } platform_set_drvdata(pdev, rtc); - printk(KERN_INFO "AT91 Real Time Clock driver.\n"); + dev_info(&pdev->dev, "AT91 Real Time Clock driver.\n"); return 0; }