From patchwork Fri Feb 15 06:00:03 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 220639 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-gg0-x238.google.com (mail-gg0-x238.google.com [IPv6:2607:f8b0:4002:c02::238]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 81C832C0077 for ; Fri, 15 Feb 2013 17:00:08 +1100 (EST) Received: by mail-gg0-f184.google.com with SMTP id v1sf97508ggn.21 for ; Thu, 14 Feb 2013 22:00:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=iLwj5hUQdEefD8muMrTJxBrVKwaI5z+6wUyCWCNbPzk=; b=BifrXl9CZ0WP9Ccr0kZS468cGwpchQeHc6YebaZneTDPCyRDkV35G7jmopsJoeEcSn OduFlvU2A/S87YMiSrwgvLp4Pfg/1nKWkTMD2YIJdQ86GAl/FkzdmJCEb25RRhUh7Qrl gUlOy3xN3g9h0A2IaApp+puGJkX9SyWNmgcOIN/oTiDEIlUZRWKbsMZiOJz68wjTeuv5 ysxrt18NiUA6K+GPC11J6ZkbdleKYE0Wxk8HIGKEr0sP3didOAKBlMYvxezlSrtNOuWg k/vmAJ/NTcA99ZEyzZY/WoFnZCjP0tuOYM0Dr+b1ZVINlsuSsbTwnbCDSuZh0V6qUrDj Wk/g== X-Received: by 10.50.46.167 with SMTP id w7mr78722igm.9.1360908005751; Thu, 14 Feb 2013 22:00:05 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.36.228 with SMTP id t4ls303682igj.22.canary; Thu, 14 Feb 2013 22:00:05 -0800 (PST) X-Received: by 10.68.203.201 with SMTP id ks9mr172992pbc.7.1360908005425; Thu, 14 Feb 2013 22:00:05 -0800 (PST) X-Received: by 10.68.203.201 with SMTP id ks9mr172991pbc.7.1360908005416; Thu, 14 Feb 2013 22:00:05 -0800 (PST) Received: from mailout4.samsung.com (mailout4.samsung.com. [203.254.224.34]) by gmr-mx.google.com with ESMTP id x3si11249943paw.1.2013.02.14.22.00.05; Thu, 14 Feb 2013 22:00:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) client-ip=203.254.224.34; Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MI80009QZBDV5G0@mailout4.samsung.com> for rtc-linux@googlegroups.com; Fri, 15 Feb 2013 15:00:04 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.48]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id B3.E5.06456.4EECD115; Fri, 15 Feb 2013 15:00:04 +0900 (KST) X-AuditID: cbfee68e-b7fc26d000001938-73-511dcee4df27 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 63.26.03918.3EECD115; Fri, 15 Feb 2013 15:00:04 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MI8006SBZC3XMX0@mmp1.samsung.com> for rtc-linux@googlegroups.com; Fri, 15 Feb 2013 15:00:03 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <001201ce0b41$4900c4d0$db024e70$%han@samsung.com> In-reply-to: <001201ce0b41$4900c4d0$db024e70$%han@samsung.com> Subject: [rtc-linux] [PATCH 05/11] rtc: rtc-rs5c372: use dev_dbg()/dev_warn() instead of printk()/pr_debug() Date: Fri, 15 Feb 2013 15:00:03 +0900 Message-id: <001601ce0b41$b29ff410$17dfdc30$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4LQUiQnZ5yIGDDRaO8BQe4Zm4AfgAAFUkw X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPIsWRmVeSWpSXmKPExsVy+t8zA90n52QDDZ6tZrXY39nB6MDosWfi SbYAxigum5TUnMyy1CJ9uwSujE2r0wpmCFR0XF3J2sA4m7eLkZNDQsBEon3zT0YIW0ziwr31 bF2MXBxCAssYJSb3fmKEKdqz5jQLiC0ksIhRomNNFETRTCaJB92PWUESbAJqEl++HGbvYuTg EBHQl2hr0QCpYRboZZQ407ubHaLZVmLCp3XMIDangJ3E9z8P2UBsYYEkiYldEDaLgKpEz5pJ YDW8QPX3pz5mgbAFJX5MvgdmMwtoSWze1sQKYctLbF7zlhlkr4SAusSjv7ogYREBI4m/B6cx QpSISOx78Y4R5B4JgUXsEv//zmCH2CUg8W3yIRaIXlmJTQeYIf6VlDi44gbLBEaJWUg2z0Ky eRaSzbOQrFjAyLKKUTS1ILmgOCm9yEivODG3uDQvXS85P3cTIySy+nYw3jxgfYgxGWj9RGYp 0eR8YGTmlcQbGhubmJmYmphbmpqbkiasJM4rf0kmUEggPbEkNTs1tSC1KL6oNCe1+BAjEwen VANj0o0y7/algpG71x0wus4/+/fMqqJyDoVPnzhXV1skyG5qvn3l7C79m0przc7GXzE6azNf Tbx83etH7Q8K3RZM5V/3ofJPpnzRNE9Gw+DmU1xTe/dEbjxwaIJmibQo2wxDFpu+3JKLHoF/ Q53+7b4UKPpkbfMn6xnu7jYsM01nyfO8tp8qe2eLEktxRqKhFnNRcSIAVKLoOcICAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmleLIzCtJLcpLzFFi42I5/e+xgO6Tc7KBBn/yLfZ3djA6MHrsmXiS LYAxqoHRJiM1MSW1SCE1Lzk/JTMv3VbJOzjeOd7UzMBQ19DSwlxJIS8xN9VWycUnQNctMwdo qpJCWWJOKVAoILG4WEnfDtOE0BA3XQuYxghd35AguB4jAzSQsI4xY9PqtIIZAhUdV1eyNjDO 5u1i5OSQEDCR2LPmNAuELSZx4d56NhBbSGARo0THmqguRi4geyaTxIPux6wgCTYBNYkvXw6z dzFycIgI6Eu0tWiA1DAL9DJKnOndzQ7RbCsx4dM6ZhCbU8BO4vufh2BDhQWSJCZ2QdgsAqoS PWsmgdXwAtXfn/qYBcIWlPgx+R6YzSygJbF5WxMrhC0vsXnNW2aQvRIC6hKP/uqChEUEjCT+ HpzGCFEiIrHvxTvGCYxCs5BMmoVk0iwkk2YhaVnAyLKKUTS1ILmgOCk911CvODG3uDQvXS85 P3cTIzhqn0ntYFzZYHGIUYCDUYmHV0BCNlCINbGsuDL3EKMEB7OSCO+aEKAQb0piZVVqUX58 UWlOavEhxmSgRycyS4km5wMTSl5JvKGxiZmRpZGZhZGJuTlpwkrivIynngQICaQnlqRmp6YW pBbBbGHi4JRqYAw831/xUIyrZvL0kLctsT+3SFVn2FybpSRsMdlBtP7RHOPN3mvfC35eZrpO 9+GCa0XzvVaL2v38vHuqIxOv6ae8/Pz9MqfWxUcxn/DXX6c7d9rGGw4HVm3XspF/mLhl7seI u8d+Jd/1ObnS5WvgtK7NG1fIz7W2MjUubBG5xz3/2/aPaWyMGYeUWIozEg21mIuKEwHlbeR4 HgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko Fixed the checkpatch warning as below: WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... Signed-off-by: Jingoo Han --- drivers/rtc/rtc-rs5c372.c | 10 ++++------ 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-rs5c372.c b/drivers/rtc/rtc-rs5c372.c index 76f565a..581739f 100644 --- a/drivers/rtc/rtc-rs5c372.c +++ b/drivers/rtc/rtc-rs5c372.c @@ -311,8 +311,7 @@ static int rs5c_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled) buf &= ~RS5C_CTRL1_AALE; if (i2c_smbus_write_byte_data(client, addr, buf) < 0) { - printk(KERN_WARNING "%s: can't update alarm\n", - rs5c->rtc->name); + dev_warn(dev, "can't update alarm\n"); status = -EIO; } else rs5c->regs[RS5C_REG_CTRL1] = buf; @@ -381,7 +380,7 @@ static int rs5c_set_alarm(struct device *dev, struct rtc_wkalrm *t) addr = RS5C_ADDR(RS5C_REG_CTRL1); buf[0] = rs5c->regs[RS5C_REG_CTRL1] & ~RS5C_CTRL1_AALE; if (i2c_smbus_write_byte_data(client, addr, buf[0]) < 0) { - pr_debug("%s: can't disable alarm\n", rs5c->rtc->name); + dev_dbg(dev, "can't disable alarm\n"); return -EIO; } rs5c->regs[RS5C_REG_CTRL1] = buf[0]; @@ -395,7 +394,7 @@ static int rs5c_set_alarm(struct device *dev, struct rtc_wkalrm *t) for (i = 0; i < sizeof(buf); i++) { addr = RS5C_ADDR(RS5C_REG_ALARM_A_MIN + i); if (i2c_smbus_write_byte_data(client, addr, buf[i]) < 0) { - pr_debug("%s: can't set alarm time\n", rs5c->rtc->name); + dev_dbg(dev, "can't set alarm time\n"); return -EIO; } } @@ -405,8 +404,7 @@ static int rs5c_set_alarm(struct device *dev, struct rtc_wkalrm *t) addr = RS5C_ADDR(RS5C_REG_CTRL1); buf[0] = rs5c->regs[RS5C_REG_CTRL1] | RS5C_CTRL1_AALE; if (i2c_smbus_write_byte_data(client, addr, buf[0]) < 0) - printk(KERN_WARNING "%s: can't enable alarm\n", - rs5c->rtc->name); + dev_warn(dev, "can't enable alarm\n"); rs5c->regs[RS5C_REG_CTRL1] = buf[0]; }