From patchwork Fri Feb 15 05:59:32 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 220638 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-yh0-x23b.google.com (mail-yh0-x23b.google.com [IPv6:2607:f8b0:4002:c01::23b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id B12C42C0077 for ; Fri, 15 Feb 2013 16:59:38 +1100 (EST) Received: by mail-yh0-f59.google.com with SMTP id q11sf998754yhf.14 for ; Thu, 14 Feb 2013 21:59:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-cr-hashedpuzzle:x-cr-puzzleid :x-brightmail-tracker:x-brightmail-tracker:dlp-filter:x-mtr :x-cfilter-loop:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:x-google-group-id :list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type:content-language; bh=CoIsUDZvBUmENTnfYalN5GgK+AG6eCBA0aD+1vua+io=; b=RY/v7lO4iPBtbCTIQ+BHGWMGGIk/IF974UToFzxEC1dr5XGgLU7wDC0zxi510CBAUN xiuuPFlnCMz7WrAQqLDwPPD6qG4xEZOGKGxvj5cvbdkPxKAKVU3Fi8EkYo6AzReyUcg0 pE492wYufZFyyfMTPcuujdxfjQAA4xzkGRb8lUia2lX59tzqQ5+TdO8EOWtwnX9E93cT V0Nlt2cPJlqQ1WSSsLXcuRnYAsI6NHSGnUkbBszMns8C1xpfEDTUgb9GPmi+bcONA+Az wC/CZYWscdNesZ46uGBcP8Y0/BLwGruzLcqIJsOMb5MMKpX28GsmUZs29MmO9WgkBZbf BkBQ== X-Received: by 10.50.214.36 with SMTP id nx4mr170757igc.6.1360907974329; Thu, 14 Feb 2013 21:59:34 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.12.233 with SMTP id b9ls297740igc.4.gmail; Thu, 14 Feb 2013 21:59:34 -0800 (PST) X-Received: by 10.66.72.199 with SMTP id f7mr976485pav.12.1360907974058; Thu, 14 Feb 2013 21:59:34 -0800 (PST) X-Received: by 10.66.72.199 with SMTP id f7mr976484pav.12.1360907974046; Thu, 14 Feb 2013 21:59:34 -0800 (PST) Received: from mailout4.samsung.com (mailout4.samsung.com. [203.254.224.34]) by gmr-mx.google.com with ESMTP id d9si61960paw.0.2013.02.14.21.59.33; Thu, 14 Feb 2013 21:59:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) client-ip=203.254.224.34; Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MI800NTKZAR4DG0@mailout4.samsung.com> for rtc-linux@googlegroups.com; Fri, 15 Feb 2013 14:59:33 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.49]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id 22.5E.03448.5CECD115; Fri, 15 Feb 2013 14:59:33 +0900 (KST) X-AuditID: cbfee68f-b7f656d000000d78-c7-511dcec5f542 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 7B.9E.03880.4CECD115; Fri, 15 Feb 2013 14:59:33 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MI8004EVZB88H50@mmp2.samsung.com> for rtc-linux@googlegroups.com; Fri, 15 Feb 2013 14:59:32 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <001201ce0b41$4900c4d0$db024e70$%han@samsung.com> In-reply-to: <001201ce0b41$4900c4d0$db024e70$%han@samsung.com> Subject: [rtc-linux] [PATCH 04/11] rtc: rtc-ds2404: use dev_err() instead of printk() Date: Fri, 15 Feb 2013 14:59:32 +0900 Message-id: <001501ce0b41$a0368370$e0a38a50$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4LQUiQnZ5yIGDDRaO8BQe4Zm4AfgAADxZA x-cr-hashedpuzzle: F7KT J3dp RCkr SojQ fTw/ f31h gDWi hOgX hdZ0 iVXF ooxc pN0U prw3 sq98 t7fk uNtb; 5; YQAuAHoAdQBtAG0AbwBAAHQAbwB3AGUAcgB0AGUAYwBoAC4AaQB0ADsAYQBrAHAAbQBAAGwAaQBuAHUAeAAtAGYAbwB1AG4AZABhAHQAaQBvAG4ALgBvAHIAZwA7AGoAZwAxAC4AaABhAG4AQABzAGEAbQBzAHUAbgBnAC4AYwBvAG0AOwBsAGkAbgB1AHgALQBrAGUAcgBuAGUAbABAAHYAZwBlAHIALgBrAGUAcgBuAGUAbAAuAG8AcgBnADsAcgB0AGMALQBsAGkAbgB1AHgAQABnAG8AbwBnAGwAZQBnAHIAbwB1AHAAcwAuAGMAbwBtAA==; Sosha1_v1; 7; {13DF5FAD-4F7D-4F81-8E2E-050855A443A7}; agBnADEALgBoAGEAbgBAAHMAYQBtAHMAdQBuAGcALgBjAG8AbQA=; Fri, 15 Feb 2013 05:59:25 GMT; WwBQAEEAVABDAEgAIAAwADQALwAxADEAXQAgAHIAdABjADoAIAByAHQAYwAtAGQAcwAyADQAMAA0ADoAIAB1AHMAZQAgAGQAZQB2AF8AZQByAHIAKAApACAAaQBuAHMAdABlAGEAZAAgAG8AZgAgAHAAcgBpAG4AdABrACgAKQA= x-cr-puzzleid: {13DF5FAD-4F7D-4F81-8E2E-050855A443A7} X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrKIsWRmVeSWpSXmKPExsVy+t8zQ92j52QDDa4+57DY39nB6MDosWfi SbYAxigum5TUnMyy1CJ9uwSujDVfZAr+cFQsetbC1sA4m72LkYNDQsBEYun9oi5GTiBTTOLC vfVsXYxcHEICyxglula0MEIkTCT2/dzJCmILCUxnlDjwrh6iaCaTxMS2a+wgCTYBNYkvXw6D DRUR0Jdoa9EAqWEW6GWUONO7mx2i2VZiwqd1zCA2p4CdxPc/D9lAbGEBT4mj+x4zgvSyCKhK tDwEK+EFKn//vJcVwhaU+DH5HguIzSygJbF5WxMrhC0vsXnNW2aIX9QlHv3VhbjASOLsNTaI ChGJfS/eMYJcIyHwglVi+pMPTBBvmUrc2TCDHSKxi13iz9cPYGeyCAhIfJt8iAVipqzEpgPM EPWSEgdX3GCZwCg1C8lFs5BcNAvJRbOQ7F7AyLKKUTS1ILmgOCm9yFivODG3uDQvXS85P3cT IyQK+3cw3j1gfYgxGWj9RGYp0eR8YBTnlcQbGhubmJmYmphbmpqbkiasJM4rf0kmUEggPbEk NTs1tSC1KL6oNCe1+BAjEwenVAOjJLvXz6C0uy12V77xLQg9Zh5gvbRh9+5t05K2eHjk72h4 0tZwN2HJmW27bnLe/9LjtJdX5TC3sVVUhPe8RQ7R+f4seo5GnEz2lgsn6wpIGQXlZhm967a+ eFKbo+jny90yj+xXvzwrsExQ831rkOm0VJldXrN/98X86jyXeEdov3jTvsTfkR+VWIozEg21 mIuKEwEPoKyZ2AIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMKsWRmVeSWpSXmKPExsVy+t9jQd2j52QDDd7eYbHY39nB6MDosWfi SbYAxqgGRpuM1MSU1CKF1Lzk/JTMvHRbJe/geOd4UzMDQ11DSwtzJYW8xNxUWyUXnwBdt8wc oLFKCmWJOaVAoYDE4mIlfTtME0JD3HQtYBojdH1DguB6jAzQQMI6xow1X2QK/nBULHrWwtbA OJu9i5GTQ0LARGLfz52sELaYxIV769lAbCGB6YwSB97VdzFyAdkzmSQmtl0Da2ATUJP48uUw kM3BISKgL9HWogFSwyzQyyhxpnc3O0SzrcSET+uYQWxOATuJ738egg0VFvCUOLrvMSNIL4uA qkTLQ7ASXqDy9897WSFsQYkfk++xgNjMAloSm7c1sULY8hKb17xlBmmVEFCXePRXF+ICI4mz 19ggKkQk9r14xwhyjYTAC1aJ6U8+MEG8ZSpxZ8MM9gmMIrOQbJiFZMMsJBtmIZm1gJFlFaNo akFyQXFSeq6RXnFibnFpXrpecn7uJkZwlD+T3sG4qsHiEKMAB6MSD6+AhGygEGtiWXFl7iFG CQ5mJRHeNSFAId6UxMqq1KL8+KLSnNTiQ4zJQP9PZJYSTc4HJqC8knhDYxMzI0sjMwsjE3Nz 0oSVxHkZTz0JEBJITyxJzU5NLUgtgtnCxMEp1cBoZvlycubekxd2N+lMiVQW/LNsKbd18kVB 3n/qi8zM1xSmrruTyqNtMHvSq9vKa9409vWIuGbuPJlQ4N/PEbs0cc3F5VccTr3OjfDxaKoR PmwQdnO7Mdv36H65qzJdpQktJ4/09183dL6rGNW/+pvpRK1DB7eJuy3dlsTWohegOzOGX3LW /HlKLMUZiYZazEXFiQCHNOYgNgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko Fixed the checkpatch warning as below: WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... Signed-off-by: Jingoo Han --- drivers/rtc/rtc-ds2404.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-ds2404.c b/drivers/rtc/rtc-ds2404.c index 4539e37..b04fc42 100644 --- a/drivers/rtc/rtc-ds2404.c +++ b/drivers/rtc/rtc-ds2404.c @@ -70,7 +70,7 @@ static int ds2404_gpio_map(struct ds2404 *chip, struct platform_device *pdev, for (i = 0; i < ARRAY_SIZE(ds2404_gpio); i++) { err = gpio_request(ds2404_gpio[i].gpio, ds2404_gpio[i].name); if (err) { - printk(KERN_ERR "error mapping gpio %s: %d\n", + dev_err(&pdev->dev, "error mapping gpio %s: %d\n", ds2404_gpio[i].name, err); goto err_request; } @@ -177,7 +177,7 @@ static void ds2404_write_memory(struct device *dev, u16 offset, for (i = 0; i < length; i++) { if (out[i] != ds2404_read_byte(dev)) { - printk(KERN_ERR "read invalid data\n"); + dev_err(dev, "read invalid data\n"); return; } }