From patchwork Fri Feb 15 05:58:11 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 220636 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-qa0-f60.google.com (mail-qa0-f60.google.com [209.85.216.60]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 00E6B2C0085 for ; Fri, 15 Feb 2013 16:58:15 +1100 (EST) Received: by mail-qa0-f60.google.com with SMTP id o13sf171940qaj.15 for ; Thu, 14 Feb 2013 21:58:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=GXgA03JFZBWCbgAEMpfPkS45SqhEbF867l1rIKcAajY=; b=yQrZ7Y8XgS6O42ET5NiEAJr7P6JMhp0ftzDb8wx5EZ/pCLYRAkDiCHtX/1jc3d2Lpv epGfoSAnrTp0KDYCgDpmEihquwShVKM9dA2Nb34J2LAqjw7tHv1GdjE038r2KoDhtUmZ /2M/YFOD5UyNskCcm7/F0ZntEl1zjjDtZEU4hyHcn7kZSkAOaZ9XSnGj6odsIBTc0OPd Pz1Kk6wUExhIv/sDA+0UPiU4VxYyueIJG98qWKeUwOMy3A0Xw4UJV/0zazfIipv5jZxb B8svyN4TbPm/KtfPQx2adP8er5sbSbMcNbNKPpPZHI6iZNuiLANOjh66uuy1GheQ7pHm ZacA== X-Received: by 10.50.152.232 with SMTP id vb8mr162914igb.16.1360907893030; Thu, 14 Feb 2013 21:58:13 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.12.233 with SMTP id b9ls297392igc.4.gmail; Thu, 14 Feb 2013 21:58:12 -0800 (PST) X-Received: by 10.66.90.67 with SMTP id bu3mr894144pab.45.1360907892593; Thu, 14 Feb 2013 21:58:12 -0800 (PST) X-Received: by 10.66.90.67 with SMTP id bu3mr894143pab.45.1360907892580; Thu, 14 Feb 2013 21:58:12 -0800 (PST) Received: from mailout1.samsung.com (mailout1.samsung.com. [203.254.224.24]) by gmr-mx.google.com with ESMTP id tj3si596121pbc.0.2013.02.14.21.58.12; Thu, 14 Feb 2013 21:58:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) client-ip=203.254.224.24; Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MI800CV2Z8REKI0@mailout1.samsung.com> for rtc-linux@googlegroups.com; Fri, 15 Feb 2013 14:58:11 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.48]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id 73.CA.05791.37ECD115; Fri, 15 Feb 2013 14:58:11 +0900 (KST) X-AuditID: cbfee690-b7f066d00000169f-9a-511dce73243e Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 80.95.03918.37ECD115; Fri, 15 Feb 2013 14:58:11 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MI8007L3Z8Z8LZ0@mmp1.samsung.com> for rtc-linux@googlegroups.com; Fri, 15 Feb 2013 14:58:11 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <001201ce0b41$4900c4d0$db024e70$%han@samsung.com> In-reply-to: <001201ce0b41$4900c4d0$db024e70$%han@samsung.com> Subject: [rtc-linux] [PATCH 02/11] rtc: max77686: use dev_info() instead of printk() Date: Fri, 15 Feb 2013 14:58:11 +0900 Message-id: <001301ce0b41$6f9b46b0$4ed1d410$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4LQUiQnZ5yIGDDRaO8BQe4Zm4AfgAAArzQ X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrAIsWRmVeSWpSXmKPExsVy+t8zA93ic7KBBttPalrs7+xgdGD02DPx JFsAYxSXTUpqTmZZapG+XQJXxoXmo2wFXzgqjk6/ydTAuJW9i5GTQ0LAROLkmuUsELaYxIV7 69m6GLk4hASWMUrcPHGeGabo4J4LTBCJRYwSp9qPQFXNZJJ4eXYqWDubgJrEly+HgcZycIgI 6Eu0tWiA1DAL9DJKnOndDbZOSMBWYsKndWBTOQXsJL7/ecgGYgsLeEhsa5vODNLLIqAqcasv ESTMC1T+5epLNghbUOLH5Htgq5gFtCQ2b2tihbDlJTaveQvWKiGgLvHory5IWETASKJ511F2 iBIRiX0v3jGCnCMhsIxdYteV7UwgCRYBAYlvkw+xQPTKSmw6APWvpMTBFTdYJjBKzEKyeRaS zbOQbJ6FZMUCRpZVjKKpBckFxUnpRSZ6xYm5xaV56XrJ+bmbGCGxNWEH470D1ocYk4HWT2SW Ek3OB8ZmXkm8obGxiZmJqYm5pam5KWnCSuK88pdkAoUE0hNLUrNTUwtSi+KLSnNSiw8xMnFw SjUwGuazuzicC63nqFNeE8cQMVtkC5u5zd2oLPmNm2Za50XZal5h3/M3NqSbM+bm/DWbePRm 32NbN0s8pOwCi6zLM4mLNjK3bl26qMLZ3Ci26krvtLlbz0t/clcUs3poF+KW+shZd7ZI8KHQ 8Gcp527M0fKzDK43kPopneW0tpFLbN7leFnZwzFKLMUZiYZazEXFiQDgZ0ZTwwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplleLIzCtJLcpLzFFi42I5/e+xgG7xOdlAg1M7VC32d3YwOjB67Jl4 ki2AMaqB0SYjNTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMH aKySQlliTilQKCCxuFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCOMeNC81G2gi8cFUen32Rq YNzK3sXIySEhYCJxcM8FJghbTOLCvfVsXYxcHEICixglTrUfgXJmMkm8PDuVBaSKTUBN4suX w0DdHBwiAvoSbS0aIDXMAr2MEmd6d4NNFRKwlZjwaR0ziM0pYCfx/c9DNhBbWMBDYlvbdGaQ XhYBVYlbfYkgYV6g8i9XX7JB2IISPybfA1vFLKAlsXlbEyuELS+xec1bsFYJAXWJR391QcIi AkYSzbuOskOUiEjse/GOcQKj0Cwkk2YhmTQLyaRZSFoWMLKsYhRNLUguKE5KzzXUK07MLS7N S9dLzs/dxAiO3GdSOxhXNlgcYhTgYFTi4RWQkA0UYk0sK67MPcQowcGsJMK7JgQoxJuSWFmV WpQfX1Sak1p8iDEZ6M+JzFKiyfnApJJXEm9obGJmZGlkZmFkYm5OmrCSOC/jqScBQgLpiSWp 2ampBalFMFuYODilGhh3WD63m/u+vIR3Zrvs5lNX13yy8Ci4FFqw7m3chp4JLX7KdvO/7Im8 dXDb35WFE+u+rPl+XLbTrPX41H8nRdn7PlTY5V/LvaFgvKNz8rXm1c73PbbYF/7WFrL9aJHz eq5vTvvXshOsn3TK13H9YDWKehBVYnw2QeNsxu6VN5IeGFyzqSgzrRRTYinOSDTUYi4qTgQA TVbS3CADAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.24 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko Fixed the checkpatch warning as below: WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... Signed-off-by: Jingoo Han --- drivers/rtc/rtc-max77686.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c index 2da0855..abe27c0 100644 --- a/drivers/rtc/rtc-max77686.c +++ b/drivers/rtc/rtc-max77686.c @@ -507,7 +507,7 @@ static int max77686_rtc_probe(struct platform_device *pdev) struct max77686_rtc_info *info; int ret, virq; - printk(KERN_INFO "%s\n", __func__); + dev_info(&pdev->dev, "%s\n", __func__); info = kzalloc(sizeof(struct max77686_rtc_info), GFP_KERNEL); if (!info) @@ -546,7 +546,7 @@ static int max77686_rtc_probe(struct platform_device *pdev) &max77686_rtc_ops, THIS_MODULE); if (IS_ERR(info->rtc_dev)) { - printk(KERN_INFO "%s: fail\n", __func__); + dev_info(&pdev->dev, "%s: fail\n", __func__); ret = PTR_ERR(info->rtc_dev); dev_err(&pdev->dev, "Failed to register RTC device: %d\n", ret);