From patchwork Thu Feb 14 17:46:02 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Carlini X-Patchwork-Id: 220475 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 0BFC82C0082 for ; Fri, 15 Feb 2013 04:46:32 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1361468793; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:Message-ID:Date:From:User-Agent:MIME-Version: To:CC:Subject:References:In-Reply-To:Content-Type:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=MdrwK90Ot+OYF1jdRmsOaNi8/rM=; b=B07Gpy1y8t88qNsNYN29206n74ALvYP0JJDZRuH85n2vWCwaaDMc0AFmfUCUzx WFF2jfyho5V4ZdcDEBZNgSkzW5iZFyCmFLA+E+Y2DvNJrESpWkeQOUefXc5kXN9i dURhgS16XVB+lwrvUXKcp9JOoFV30OQ/QY2FbxpDQF2oQ= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=fkq3Txyam0oFKBxu/XXSk4OcviQNUlTuBuzNLwNWZ0sbh/tSlARUaJoQyY0R95 +4kTbruMrBykXzO6z4qbff/dKZ33v5r7F6u/wGLXHv+fJzYu7FflBUXh091Ltxmt DxW9XAqsf8ruZ2qsm7TSOmQHnrXdWTpe2SSdo+tjGpn68=; Received: (qmail 1761 invoked by alias); 14 Feb 2013 17:46:19 -0000 Received: (qmail 1738 invoked by uid 22791); 14 Feb 2013 17:46:17 -0000 X-SWARE-Spam-Status: No, hits=-4.2 required=5.0 tests=AWL, BAYES_00, FSL_NEW_HELO_USER, KHOP_THREADED, RCVD_IN_HOSTKARMA_NO, RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from userp1040.oracle.com (HELO userp1040.oracle.com) (156.151.31.81) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Feb 2013 17:46:11 +0000 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r1EHk6bq017096 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 14 Feb 2013 17:46:07 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r1EHk57h011988 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 14 Feb 2013 17:46:06 GMT Received: from abhmt117.oracle.com (abhmt117.oracle.com [141.146.116.69]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id r1EHk4Ts016006; Thu, 14 Feb 2013 11:46:04 -0600 Received: from [192.168.1.4] (/79.40.56.59) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 14 Feb 2013 09:46:04 -0800 Message-ID: <511D22DA.8040706@oracle.com> Date: Thu, 14 Feb 2013 18:46:02 +0100 From: Paolo Carlini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2 MIME-Version: 1.0 To: Rainer Orth CC: Jason Merrill , gcc-patches List , libstdc++ Subject: Re: RFA: v3 PATCH to add on_quick_exit/quick_exit to std References: <51192B59.4000305@redhat.com> In-Reply-To: X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hi Rainer, On 02/14/2013 04:45 PM, Rainer Orth wrote: > Jason Merrill writes: > >> While I was going over the C++11 status page, I noticed that quick_exit is >> implemented by glibc, it just needed to be added to the libstdc++ cstdlib >> header. > The test fails on Solaris 9: > > FAIL: 18_support/quick_exit/quick_exit.cc (test for excess errors) > Excess errors: > /vol/gcc/src/hg/trunk/local/libstdc++-v3/testsuite/18_support/quick_exit/quick_e > xit.cc:28:3: error: '_Exit' is not a member of 'std' > > WARNING: 18_support/quick_exit/quick_exit.cc compilation failed to produce execu > table > extra_tool_flags are: > -std=gnu++11 > > _Exit seems to be a C99 addition, only present since Solaris 10. Indeed. Given the very simple nature of the testcase, I think something like the below can do, at least for 4.8.0, if Jason has no objections. Can you double check it on Solaris and in case commit it? Thanks, Paolo. ///////////////////// Index: testsuite/18_support/quick_exit/quick_exit.cc =================================================================== --- testsuite/18_support/quick_exit/quick_exit.cc (revision 196056) +++ testsuite/18_support/quick_exit/quick_exit.cc (working copy) @@ -25,7 +25,9 @@ void handler() { +#if _GLIBCXX_USE_C99 std::_Exit(0); +#endif } void wrong_handler()