From patchwork Thu Feb 14 05:14:10 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nathan Hintz X-Patchwork-Id: 220352 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id D2D802C029C for ; Thu, 14 Feb 2013 16:21:30 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751423Ab3BNFV1 (ORCPT ); Thu, 14 Feb 2013 00:21:27 -0500 Received: from blu0-omc1-s4.blu0.hotmail.com ([65.55.116.15]:17309 "EHLO blu0-omc1-s4.blu0.hotmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751101Ab3BNFV0 (ORCPT ); Thu, 14 Feb 2013 00:21:26 -0500 X-Greylist: delayed 370 seconds by postgrey-1.27 at vger.kernel.org; Thu, 14 Feb 2013 00:21:26 EST Received: from BLU0-SMTP79 ([65.55.116.9]) by blu0-omc1-s4.blu0.hotmail.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 13 Feb 2013 21:15:15 -0800 X-EIP: [cAmpRqQgnet1L+L9mpnEaDnqFVFYRaYZ] X-Originating-Email: [nlhintz@hotmail.com] Message-ID: Received: from hintzn1linux.lan ([76.121.243.176]) by BLU0-SMTP79.phx.gbl over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Wed, 13 Feb 2013 21:15:14 -0800 From: Nathan Hintz To: davem@davemloft.net CC: netdev@vger.kernel.org, hauke@hauke-m.de, zajec5@gmail.com, Nathan Hintz Subject: [PATCH] bgmac: add read of interrupt mask after disabling interrupts Date: Wed, 13 Feb 2013 21:14:10 -0800 X-Mailer: git-send-email 1.7.7.6 X-OriginalArrivalTime: 14 Feb 2013 05:15:14.0335 (UTC) FILETIME=[452B7AF0:01CE0A72] MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The specs prescribe an immediate read of the interrupt mask after disabling interrupts. This patch updates the driver to match the specs. Signed-off-by: Nathan Hintz --- drivers/net/ethernet/broadcom/bgmac.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c index 52d9a54..d341090 100644 --- a/drivers/net/ethernet/broadcom/bgmac.c +++ b/drivers/net/ethernet/broadcom/bgmac.c @@ -974,6 +974,7 @@ static void bgmac_chip_intrs_on(struct bgmac *bgmac) static void bgmac_chip_intrs_off(struct bgmac *bgmac) { bgmac_write(bgmac, BGMAC_INT_MASK, 0); + bgmac_read(bgmac, BGMAC_INT_MASK); } /* http://bcm-v4.sipsolutions.net/mac-gbit/gmac/gmac_enable */