From patchwork Wed Feb 13 21:36:49 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Otavio Salvador X-Patchwork-Id: 220263 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 749782C0085 for ; Thu, 14 Feb 2013 08:37:06 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 5985F4A187; Wed, 13 Feb 2013 22:37:03 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TuXJnxTXzDw3; Wed, 13 Feb 2013 22:37:03 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id E81C14A171; Wed, 13 Feb 2013 22:37:00 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id E2DC84A17D for ; Wed, 13 Feb 2013 22:36:58 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kKqKJXHq9E6S for ; Wed, 13 Feb 2013 22:36:58 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-oa0-f43.google.com (mail-oa0-f43.google.com [209.85.219.43]) by theia.denx.de (Postfix) with ESMTPS id 45E414A177 for ; Wed, 13 Feb 2013 22:36:51 +0100 (CET) Received: by mail-oa0-f43.google.com with SMTP id l10so1816812oag.2 for ; Wed, 13 Feb 2013 13:36:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=CNnG1DRvw4c5utDsy8nuvPIouRBPIUq73coE6D/1X+8=; b=KjvU28FyywoyRKU+s0vE0JVe/hCi31kNaO2HITu77in+WIGT52n1FZ1LQDp6o9UOWc II2cl/8FQCil4wdt7M72PF7vZWRPqzvAxyZbtNpX7JNOvobWShC+bprvq+6xWztKjhQj vv29w6qrqfhPZRXRyKjhAlceE62w382h4+XhYt5KwMiWleHiF/dGwgyFKg/Ie0l9NoPv H0ZDpNtJOYqGlITHgB3I+wGIFFRfHQN0EjvcYy1jjBwqlJNTkt5wxAaophax2352O3Yj 6DF01WO8fVT5KQb++wLKuLo56X6QtFPfIdeB1CsbKv+uh0Bt3RMGIZHmirPCqi0OIsj8 ruvw== MIME-Version: 1.0 X-Received: by 10.182.3.163 with SMTP id d3mr17792339obd.27.1360791409756; Wed, 13 Feb 2013 13:36:49 -0800 (PST) Received: by 10.182.2.197 with HTTP; Wed, 13 Feb 2013 13:36:49 -0800 (PST) In-Reply-To: References: <1360589756-26355-1-git-send-email-otavio@ossystems.com.br> <1360589756-26355-3-git-send-email-otavio@ossystems.com.br> <201302132212.31940.marex@denx.de> Date: Wed, 13 Feb 2013 19:36:49 -0200 X-Google-Sender-Auth: 3CiNgKqVH57bhaP4-AC5pcJk_j0 Message-ID: From: Otavio Salvador To: Fabio Estevam Cc: Marek Vasut , Fabio Estevam , U-Boot Mailing List Subject: Re: [U-Boot] [PATCH v2 02/10] mx23: Document the tRAS lockout setting in memory initialization X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de On Wed, Feb 13, 2013 at 7:31 PM, Fabio Estevam wrote: > On Wed, Feb 13, 2013 at 7:20 PM, Otavio Salvador > wrote: > >>>> #ifdef CONFIG_MX23 >>>> + /* Enable tRAS lockout in HW_DRAM_CTL08 ; it must be after all */ >>> >>> 'After all'? >> >> For me it is clear enough; I am not native so it'd be good if a native >> English speaker could comment on this. > > I think you meant to say "it must be the last element". What about this? --- Otavio Salvador O.S. Systems E-mail: otavio@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c b/arch/arm/cpu/arm926 index f8392f6..b6a0563 100644 --- a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c +++ b/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c @@ -119,6 +119,9 @@ static void initialize_dram_values(void) writel(dram_vals[i], MXS_DRAM_BASE + (4 * i)); #ifdef CONFIG_MX23 + /* Enable tRAS lockout in HW_DRAM_CTL08 ; it must be the last + * element to be set */ writel((1 << 24), MXS_DRAM_BASE + (4 * 8)); #endif }