Patchwork [U-Boot,v2,02/10] mx23: Document the tRAS lockout setting in memory initialization

login
register
mail settings
Submitter Otavio Salvador
Date Feb. 13, 2013, 9:36 p.m.
Message ID <CAP9ODKqOHF8w_aQOWUn1xzGyCkrxDHEc92DqFNLi-EOcEa0chw@mail.gmail.com>
Download mbox | patch
Permalink /patch/220263/
State Superseded
Delegated to: Stefano Babic
Headers show

Comments

Otavio Salvador - Feb. 13, 2013, 9:36 p.m.
On Wed, Feb 13, 2013 at 7:31 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Wed, Feb 13, 2013 at 7:20 PM, Otavio Salvador
> <otavio@ossystems.com.br> wrote:
>
>>>>  #ifdef CONFIG_MX23
>>>> +     /* Enable tRAS lockout in HW_DRAM_CTL08 ; it must be after all */
>>>
>>> 'After all'?
>>
>> For me it is clear enough; I am not native so it'd be good if a native
>> English speaker could comment on this.
>
> I think you meant to say "it must be the last element".

What about this?

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Fabio Estevam - Feb. 13, 2013, 9:39 p.m.
On Wed, Feb 13, 2013 at 7:36 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> On Wed, Feb 13, 2013 at 7:31 PM, Fabio Estevam <festevam@gmail.com> wrote:
>> On Wed, Feb 13, 2013 at 7:20 PM, Otavio Salvador
>> <otavio@ossystems.com.br> wrote:
>>
>>>>>  #ifdef CONFIG_MX23
>>>>> +     /* Enable tRAS lockout in HW_DRAM_CTL08 ; it must be after all */
>>>>
>>>> 'After all'?
>>>
>>> For me it is clear enough; I am not native so it'd be good if a native
>>> English speaker could comment on this.
>>
>> I think you meant to say "it must be the last element".
>
> diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c b/arch/arm/cpu/arm926
> index f8392f6..b6a0563 100644
> --- a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
> +++ b/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
> @@ -119,6 +119,9 @@ static void initialize_dram_values(void)
>                 writel(dram_vals[i], MXS_DRAM_BASE + (4 * i));
>
>  #ifdef CONFIG_MX23
> +       /* Enable tRAS lockout in HW_DRAM_CTL08 ; it must be the last
> +        * element to be set */

I think the comment is clear, but multi-line comment should be like:

/*
 * First line bla bla bla
 * Second line bla bla bla
 */
Otavio Salvador - Feb. 13, 2013, 9:42 p.m.
On Wed, Feb 13, 2013 at 7:39 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Wed, Feb 13, 2013 at 7:36 PM, Otavio Salvador
> <otavio@ossystems.com.br> wrote:
>> On Wed, Feb 13, 2013 at 7:31 PM, Fabio Estevam <festevam@gmail.com> wrote:
>>> On Wed, Feb 13, 2013 at 7:20 PM, Otavio Salvador
>>> <otavio@ossystems.com.br> wrote:
>>>
>>>>>>  #ifdef CONFIG_MX23
>>>>>> +     /* Enable tRAS lockout in HW_DRAM_CTL08 ; it must be after all */
>>>>>
>>>>> 'After all'?
>>>>
>>>> For me it is clear enough; I am not native so it'd be good if a native
>>>> English speaker could comment on this.
>>>
>>> I think you meant to say "it must be the last element".
>>
>> diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c b/arch/arm/cpu/arm926
>> index f8392f6..b6a0563 100644
>> --- a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
>> +++ b/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
>> @@ -119,6 +119,9 @@ static void initialize_dram_values(void)
>>                 writel(dram_vals[i], MXS_DRAM_BASE + (4 * i));
>>
>>  #ifdef CONFIG_MX23
>> +       /* Enable tRAS lockout in HW_DRAM_CTL08 ; it must be the last
>> +        * element to be set */
>
> I think the comment is clear, but multi-line comment should be like:
>
> /*
>  * First line bla bla bla
>  * Second line bla bla bla
>  */

Ok; fixed for v3.

Patch

diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c b/arch/arm/cpu/arm926
index f8392f6..b6a0563 100644
--- a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
+++ b/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
@@ -119,6 +119,9 @@  static void initialize_dram_values(void)
                writel(dram_vals[i], MXS_DRAM_BASE + (4 * i));

 #ifdef CONFIG_MX23
+       /* Enable tRAS lockout in HW_DRAM_CTL08 ; it must be the last
+        * element to be set */
        writel((1 << 24), MXS_DRAM_BASE + (4 * 8));
 #endif
 }