From patchwork Wed Feb 13 16:05:05 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thierry Reding X-Patchwork-Id: 220187 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 79E482C007C for ; Thu, 14 Feb 2013 03:05:17 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759893Ab3BMQFQ (ORCPT ); Wed, 13 Feb 2013 11:05:16 -0500 Received: from moutng.kundenserver.de ([212.227.17.9]:57436 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759650Ab3BMQFP (ORCPT ); Wed, 13 Feb 2013 11:05:15 -0500 Received: from mailbox.adnet.avionic-design.de (mailbox.avionic-design.de [109.75.18.3]) by mrelayeu.kundenserver.de (node=mrbap1) with ESMTP (Nemesis) id 0MIyAj-1U3An52Xlp-002gIo; Wed, 13 Feb 2013 17:05:14 +0100 Received: from localhost (localhost [127.0.0.1]) by mailbox.adnet.avionic-design.de (Postfix) with ESMTP id E100C28B029D; Wed, 13 Feb 2013 17:05:13 +0100 (CET) X-Virus-Scanned: amavisd-new at avionic-design.de Received: from mailbox.adnet.avionic-design.de ([127.0.0.1]) by localhost (mailbox.avionic-design.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RNGpkFpyz4Ih; Wed, 13 Feb 2013 17:05:12 +0100 (CET) Received: from mailman.adnet.avionic-design.de (mailman.adnet.avionic-design.de [172.20.31.172]) by mailbox.adnet.avionic-design.de (Postfix) with ESMTP id CD5B928B02A4; Wed, 13 Feb 2013 17:05:07 +0100 (CET) Received: from localhost (avionic-0098.adnet.avionic-design.de [172.20.31.233]) by mailman.adnet.avionic-design.de (Postfix) with ESMTP id 09D641007C3; Wed, 13 Feb 2013 17:05:04 +0100 (CET) From: Thierry Reding To: Dave Airlie Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org Subject: [PATCH v3 6/7] drm/tegra: Split DC_CMD_STATE_CONTROL register write Date: Wed, 13 Feb 2013 17:05:05 +0100 Message-Id: <1360771506-17849-7-git-send-email-thierry.reding@avionic-design.de> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1360771506-17849-1-git-send-email-thierry.reding@avionic-design.de> References: <1360771506-17849-1-git-send-email-thierry.reding@avionic-design.de> X-Provags-ID: V02:K0:CAS6pQZArp4Nx6V4lvIADK7g0tHPa4SVW8R/OBv9slB EHXO4uaezA/Tn92fMqmGLh9U8Rw666vRvShE79scxIPv5rPVJg abgJ//2i7Fmm/PIiLyjCGgbofKuzsOqu8IIfZAOVQth74NOwjH ejcBQ+agsPgMVrFP7Q6uSoATMADa/Osb8+uUvnJKsbhvRO84Jb r22Bf0GPxaR5u7Ch3M70W6VvejOubbRo2ye7rHysxLqOudPeXi V47S57mS0+TTAsJHwA3HMtHPH4qVc2YdZcsuC5UkmJ90ezThbY SrXQvlaIpBANIRtRBjNwss5xkWSBcRuNaWx3vIyv4Eg336+ADP obVs9Pgprs6KIKYFs1RJQiF/kaFIm+4m+VdoFt4Yj8CEwOWp19 BOH1NuBhVX5DQ1EfO3U+KqH/Yzj1MuBywydpqghkaRkQ/XSKWA j9oVS Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org The Tegra TRM says that the ACT_REQ and UPDATE fields cannot be programmed at the same time so they are updated in two consecutive writes instead. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/dc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c index 0328963..9b2a551 100644 --- a/drivers/gpu/drm/tegra/dc.c +++ b/drivers/gpu/drm/tegra/dc.c @@ -594,9 +594,10 @@ static void tegra_crtc_commit(struct drm_crtc *crtc) struct tegra_dc *dc = to_tegra_dc(crtc); unsigned long value; - value = GENERAL_ACT_REQ | WIN_A_ACT_REQ | - GENERAL_UPDATE | WIN_A_UPDATE; + value = GENERAL_UPDATE | WIN_A_UPDATE; + tegra_dc_writel(dc, value, DC_CMD_STATE_CONTROL); + value = GENERAL_ACT_REQ | WIN_A_ACT_REQ; tegra_dc_writel(dc, value, DC_CMD_STATE_CONTROL); drm_vblank_post_modeset(crtc->dev, dc->pipe);