Patchwork flot: add fillbetween plugin.

login
register
mail settings
Submitter Arnaud Rébillout
Date Feb. 13, 2013, 3:25 p.m.
Message ID <1360769145-1610-1-git-send-email-rebillout@syscom.ch>
Download mbox | patch
Permalink /patch/220168/
State Accepted
Headers show

Comments

Arnaud Rébillout - Feb. 13, 2013, 3:25 p.m.
Flot plugin for computing bottoms for filled line and bar charts.

Signed-off-by: Arnaud Rébillout <rebillout@syscom.ch>
---
 package/flot/Config.in |    5 +++++
 package/flot/flot.mk   |    1 +
 2 files changed, 6 insertions(+)
Peter Korsgaard - March 10, 2013, 10:13 p.m.
>>>>> "Arnaud" == Arnaud Rébillout <rebillout@syscom.ch> writes:

 Arnaud> Flot plugin for computing bottoms for filled line and bar charts.
 Arnaud> Signed-off-by: Arnaud Rébillout <rebillout@syscom.ch>
 Arnaud> ---
 Arnaud>  package/flot/Config.in |    5 +++++
 Arnaud>  package/flot/flot.mk   |    1 +
 Arnaud>  2 files changed, 6 insertions(+)

 Arnaud> diff --git a/package/flot/Config.in b/package/flot/Config.in
 Arnaud> index 60534c1..0124b2d 100644
 Arnaud> --- a/package/flot/Config.in
 Arnaud> +++ b/package/flot/Config.in
 Arnaud> @@ -20,6 +20,11 @@ if BR2_PACKAGE_FLOT
 
 Arnaud>  comment "flot plugins"
 
 Arnaud> +config BR2_PACKAGE_FLOT_FILLBETWEEN
 Arnaud> +	bool "fillbetween"
 Arnaud> +	help
 Arnaud> +	  Flot plugin for computing bottoms for filled line and bar charts. 

You have a trailing space here in the help text.

Otherwise it looks good, committed - Thanks.
Arnaud Rébillout - March 11, 2013, 9:51 a.m.
You have sharp eyes !

Thanks for committing,

Regards,
Arnaud

On 03/10/2013 11:13 PM, Peter Korsgaard wrote:
>>>>>> "Arnaud" == Arnaud Rébillout<rebillout@syscom.ch>  writes:
>   Arnaud>  Flot plugin for computing bottoms for filled line and bar charts.
>   Arnaud>  Signed-off-by: Arnaud Rébillout<rebillout@syscom.ch>
>   Arnaud>  ---
>   Arnaud>   package/flot/Config.in |    5 +++++
>   Arnaud>   package/flot/flot.mk   |    1 +
>   Arnaud>   2 files changed, 6 insertions(+)
>
>   Arnaud>  diff --git a/package/flot/Config.in b/package/flot/Config.in
>   Arnaud>  index 60534c1..0124b2d 100644
>   Arnaud>  --- a/package/flot/Config.in
>   Arnaud>  +++ b/package/flot/Config.in
>   Arnaud>  @@ -20,6 +20,11 @@ if BR2_PACKAGE_FLOT
>
>   Arnaud>   comment "flot plugins"
>
>   Arnaud>  +config BR2_PACKAGE_FLOT_FILLBETWEEN
>   Arnaud>  +	bool "fillbetween"
>   Arnaud>  +	help
>   Arnaud>  +	  Flot plugin for computing bottoms for filled line and bar charts.
>
> You have a trailing space here in the help text.
>
> Otherwise it looks good, committed - Thanks.
>
Peter Korsgaard - March 11, 2013, 10:01 a.m.
>>>>> "Arnaud" == Arnaud Rébillout <rebillout@syscom.ch> writes:

 Arnaud> You have sharp eyes !

It helps that my editor highlights trailing spaces ;)

 Arnaud> Thanks for committing,

You're welcome. Thanks for constributing to buildroot.

Patch

diff --git a/package/flot/Config.in b/package/flot/Config.in
index 60534c1..0124b2d 100644
--- a/package/flot/Config.in
+++ b/package/flot/Config.in
@@ -20,6 +20,11 @@  if BR2_PACKAGE_FLOT
 
 comment "flot plugins"
 
+config BR2_PACKAGE_FLOT_FILLBETWEEN
+	bool "fillbetween"
+	help
+	  Flot plugin for computing bottoms for filled line and bar charts. 
+
 config BR2_PACKAGE_FLOT_NAVIGATE
 	bool "navigate"
 	help
diff --git a/package/flot/flot.mk b/package/flot/flot.mk
index f4ba604..41f5a42 100644
--- a/package/flot/flot.mk
+++ b/package/flot/flot.mk
@@ -1,6 +1,7 @@ 
 FLOT_VERSION = 0.7
 FLOT_SITE = http://flot.googlecode.com/files
 FLOT_FILES = jquery.flot $(addprefix jquery.flot.,\
+	$(if $(BR2_PACKAGE_FLOT_FILLBETWEEN),fillbetween) \
 	$(if $(BR2_PACKAGE_FLOT_NAVIGATE),navigate) \
 	$(if $(BR2_PACKAGE_FLOT_PIE),pie) \
 	$(if $(BR2_PACKAGE_FLOT_RESIZE),resize) \