From patchwork Wed Feb 13 11:57:55 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steffen Trumtrar X-Patchwork-Id: 220125 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-wi0-f184.google.com (mail-wi0-f184.google.com [209.85.212.184]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 2BADB2C0080 for ; Wed, 13 Feb 2013 22:58:19 +1100 (EST) Received: by mail-wi0-f184.google.com with SMTP id ez12sf320570wid.11 for ; Wed, 13 Feb 2013 03:58:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:mime-version:x-beenthere:x-received:x-received :received-spf:from:to:cc:subject:date:message-id:x-mailer :x-sa-exim-connect-ip:x-sa-exim-mail-from:x-sa-exim-scanned :x-ptx-original-recipient:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type; bh=bAnLv1TIKm04JgH3vjSenAF7PLzKsJ0UGDD7dg3ZnVg=; b=d5eXL3gU1Le+gvIcD7ip1YTLzaWRULFJteEdqbZdlK4guXNE+dY0CmMSFeCe7UyxjD 14F1n+kz/LC4Y3hji5GrLS1S9Ex5eLSp6rDWwRCXfT+PMfsBxBJjCGSXrG1xhwQ0ICmR Hh5CPqeGB8pox4IqOzes8ELsE5OzNlGfY59VhlF9hV7gGGnQJrP6VeJcNyqCgBN0TtiJ qjCGCcIVe/6Xv3ACLHCYSPAxSMuuDZh5g+BWkIKUI8UGDxCkKEy0bOq0YQrnRv5LH+1u yAVXR1zgu+TdhEqWsHwPJIs5FxTckoWiv+PyaEpYBrNfvFd71CsLdeTSH0SByDLgefq6 igOg== X-Received: by 10.180.97.168 with SMTP id eb8mr245431wib.3.1360756694544; Wed, 13 Feb 2013 03:58:14 -0800 (PST) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.180.93.69 with SMTP id cs5ls298100wib.35.gmail; Wed, 13 Feb 2013 03:58:14 -0800 (PST) X-Received: by 10.14.220.131 with SMTP id o3mr22116807eep.3.1360756694109; Wed, 13 Feb 2013 03:58:14 -0800 (PST) X-Received: by 10.14.220.131 with SMTP id o3mr22116804eep.3.1360756694086; Wed, 13 Feb 2013 03:58:14 -0800 (PST) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de. [2001:6f8:1178:4:290:27ff:fe1d:cc33]) by gmr-mx.google.com with ESMTPS id 47si69135eeh.1.2013.02.13.03.58.13 (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 13 Feb 2013 03:58:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of str@pengutronix.de designates 2001:6f8:1178:4:290:27ff:fe1d:cc33 as permitted sender) client-ip=2001:6f8:1178:4:290:27ff:fe1d:cc33; Received: from dude.hi.pengutronix.de ([2001:6f8:1178:2:21e:67ff:fe11:9c5c]) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1U5aya-00052O-Hb; Wed, 13 Feb 2013 12:58:12 +0100 Received: from str by dude.hi.pengutronix.de with local (Exim 4.80) (envelope-from ) id 1U5ayY-0000M8-0R; Wed, 13 Feb 2013 12:58:10 +0100 From: Steffen Trumtrar To: rtc-linux@googlegroups.com Cc: Alessandro Zummo , Austin Boyle , Steffen Trumtrar Subject: [rtc-linux] [PATCH] rtc: ds1307: change sysfs function pointer assignment Date: Wed, 13 Feb 2013 12:57:55 +0100 Message-Id: <1360756675-30845-1-git-send-email-s.trumtrar@pengutronix.de> X-Mailer: git-send-email 1.7.10.4 X-SA-Exim-Connect-IP: 2001:6f8:1178:2:21e:67ff:fe11:9c5c X-SA-Exim-Mail-From: str@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: rtc-linux@googlegroups.com X-Original-Sender: s.trumtrar@pengutronix.de X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of str@pengutronix.de designates 2001:6f8:1178:4:290:27ff:fe1d:cc33 as permitted sender) smtp.mail=str@pengutronix.de Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , The current usage of commas instead of semicolons is not wrong, but affects the readability of the code. Also, the code would break, iff someone would put something between those two assignments. Signed-off-by: Steffen Trumtrar --- drivers/rtc/rtc-ds1307.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c index a65621c..35f8671 100644 --- a/drivers/rtc/rtc-ds1307.c +++ b/drivers/rtc/rtc-ds1307.c @@ -960,8 +960,8 @@ read_rtc: ds1307->nvram->attr.name = "nvram"; ds1307->nvram->attr.mode = S_IRUGO | S_IWUSR; sysfs_bin_attr_init(ds1307->nvram); - ds1307->nvram->read = ds1307_nvram_read, - ds1307->nvram->write = ds1307_nvram_write, + ds1307->nvram->read = ds1307_nvram_read; + ds1307->nvram->write = ds1307_nvram_write; ds1307->nvram->size = chip->nvram_size; ds1307->nvram_offset = chip->nvram_offset; err = sysfs_create_bin_file(&client->dev.kobj, ds1307->nvram);