From patchwork Wed Feb 13 11:57:55 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: rtc: ds1307: change sysfs function pointer assignment Date: Wed, 13 Feb 2013 01:57:55 -0000 From: Steffen Trumtrar X-Patchwork-Id: 220125 Message-Id: <1360756675-30845-1-git-send-email-s.trumtrar@pengutronix.de> To: rtc-linux@googlegroups.com Cc: Alessandro Zummo , Austin Boyle , Steffen Trumtrar The current usage of commas instead of semicolons is not wrong, but affects the readability of the code. Also, the code would break, iff someone would put something between those two assignments. Signed-off-by: Steffen Trumtrar --- drivers/rtc/rtc-ds1307.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c index a65621c..35f8671 100644 --- a/drivers/rtc/rtc-ds1307.c +++ b/drivers/rtc/rtc-ds1307.c @@ -960,8 +960,8 @@ read_rtc: ds1307->nvram->attr.name = "nvram"; ds1307->nvram->attr.mode = S_IRUGO | S_IWUSR; sysfs_bin_attr_init(ds1307->nvram); - ds1307->nvram->read = ds1307_nvram_read, - ds1307->nvram->write = ds1307_nvram_write, + ds1307->nvram->read = ds1307_nvram_read; + ds1307->nvram->write = ds1307_nvram_write; ds1307->nvram->size = chip->nvram_size; ds1307->nvram_offset = chip->nvram_offset; err = sysfs_create_bin_file(&client->dev.kobj, ds1307->nvram);