Patchwork [U-Boot,2/2] spi: exynos: Fix compiler warnings for non-dt systems

login
register
mail settings
Submitter Vivek Gautam
Date Feb. 13, 2013, 6:42 a.m.
Message ID <1360737762-14056-2-git-send-email-gautam.vivek@samsung.com>
Download mbox | patch
Permalink /patch/220063/
State Changes Requested
Delegated to: Minkyu Kang
Headers show

Comments

Vivek Gautam - Feb. 13, 2013, 6:42 a.m.
Enclosing process_nodes() and spi_get_config() inside
CONFIG_OF_CONTROL, since they are compiled only for DT systems.

This fixes following warning:
exynos_spi.c:391:12: warning: 'process_nodes' defined but not used [-Wunused-function]

Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
---
 drivers/spi/exynos_spi.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Simon Glass - Feb. 14, 2013, 4:48 a.m.
On Tue, Feb 12, 2013 at 10:42 PM, Vivek Gautam <gautam.vivek@samsung.com> wrote:
> Enclosing process_nodes() and spi_get_config() inside
> CONFIG_OF_CONTROL, since they are compiled only for DT systems.
>
> This fixes following warning:
> exynos_spi.c:391:12: warning: 'process_nodes' defined but not used [-Wunused-function]
>
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>

Acked-by: Simon Glass <sjg@chromium.org>

> ---
>  drivers/spi/exynos_spi.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/spi/exynos_spi.c b/drivers/spi/exynos_spi.c
> index be60ada..2260d59 100644
> --- a/drivers/spi/exynos_spi.c
> +++ b/drivers/spi/exynos_spi.c
> @@ -360,6 +360,7 @@ static inline struct exynos_spi *get_spi_base(int dev_index)
>   * @param bus   SPI bus structure to fill with information
>   * @return 0 if ok, or -FDT_ERR_NOTFOUND if something was missing
>   */
> +#ifdef CONFIG_OF_CONTROL
>  static int spi_get_config(const void *blob, int node, struct spi_bus *bus)
>  {
>         bus->node = node;
> @@ -415,6 +416,7 @@ static int process_nodes(const void *blob, int node_list[], int count)
>
>         return 0;
>  }
> +#endif
>
>  /* Sadly there is no error return from this function */
>  void spi_init(void)
> --
> 1.7.6.5
>

Patch

diff --git a/drivers/spi/exynos_spi.c b/drivers/spi/exynos_spi.c
index be60ada..2260d59 100644
--- a/drivers/spi/exynos_spi.c
+++ b/drivers/spi/exynos_spi.c
@@ -360,6 +360,7 @@  static inline struct exynos_spi *get_spi_base(int dev_index)
  * @param bus   SPI bus structure to fill with information
  * @return 0 if ok, or -FDT_ERR_NOTFOUND if something was missing
  */
+#ifdef CONFIG_OF_CONTROL
 static int spi_get_config(const void *blob, int node, struct spi_bus *bus)
 {
 	bus->node = node;
@@ -415,6 +416,7 @@  static int process_nodes(const void *blob, int node_list[], int count)
 
 	return 0;
 }
+#endif
 
 /* Sadly there is no error return from this function */
 void spi_init(void)