| Message ID | 1360706086-31506-1-git-send-email-tipecaml@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Cyril Roelandt <tipecaml@gmail.com> Date: Tue, 12 Feb 2013 22:54:46 +0100 > cpdma_chan_destroy() on a NULL pointer is a no-op, so the NULL check in > cpdma_ctlr_destroy() can safely be removed. > > Signed-off-by: Cyril Roelandt <tipecaml@gmail.com> ... > @@ -450,8 +450,7 @@ int cpdma_ctlr_destroy(struct cpdma_ctlr *ctlr) > cpdma_ctlr_stop(ctlr); > > for (i = 0; i < ARRAY_SIZE(ctlr->channels); i++) { > - if (ctlr->channels[i]) > - cpdma_chan_destroy(ctlr->channels[i]); > + cpdma_chan_destroy(ctlr->channels[i]); > } SInce this is now a single statement basic block, remove the surrounding braces. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 02/12/2013 11:06 PM, David Miller wrote: > From: Cyril Roelandt<tipecaml@gmail.com> > Date: Tue, 12 Feb 2013 22:54:46 +0100 > >> cpdma_chan_destroy() on a NULL pointer is a no-op, so the NULL check in >> cpdma_ctlr_destroy() can safely be removed. >> >> Signed-off-by: Cyril Roelandt<tipecaml@gmail.com> > ... >> @@ -450,8 +450,7 @@ int cpdma_ctlr_destroy(struct cpdma_ctlr *ctlr) >> cpdma_ctlr_stop(ctlr); >> >> for (i = 0; i< ARRAY_SIZE(ctlr->channels); i++) { >> - if (ctlr->channels[i]) >> - cpdma_chan_destroy(ctlr->channels[i]); >> + cpdma_chan_destroy(ctlr->channels[i]); >> } > > SInce this is now a single statement basic block, remove the > surrounding braces. Ok, I resent, though I forgot to add "v2". Regards, Cyril Roelandt. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Cyril Roelandt <tipecaml@gmail.com> Date: Tue, 12 Feb 2013 23:54:41 +0100 > Ok, I resent, though I forgot to add "v2". Don't worry about that. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c index f862918..aba787b 100644 --- a/drivers/net/ethernet/ti/davinci_cpdma.c +++ b/drivers/net/ethernet/ti/davinci_cpdma.c @@ -450,8 +450,7 @@ int cpdma_ctlr_destroy(struct cpdma_ctlr *ctlr) cpdma_ctlr_stop(ctlr); for (i = 0; i < ARRAY_SIZE(ctlr->channels); i++) { - if (ctlr->channels[i]) - cpdma_chan_destroy(ctlr->channels[i]); + cpdma_chan_destroy(ctlr->channels[i]); } cpdma_desc_pool_destroy(ctlr->pool);
cpdma_chan_destroy() on a NULL pointer is a no-op, so the NULL check in cpdma_ctlr_destroy() can safely be removed. Signed-off-by: Cyril Roelandt <tipecaml@gmail.com> --- drivers/net/ethernet/ti/davinci_cpdma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)