Patchwork [U-Boot,v2,1/3] am335x-evm: enable ext4

login
register
mail settings
Submitter Koen Kooi
Date Feb. 12, 2013, 5:15 p.m.
Message ID <1360689337-20947-1-git-send-email-koen@dominion.thruhere.net>
Download mbox | patch
Permalink /patch/219916/
State Changes Requested
Delegated to: Tom Rini
Headers show

Comments

Koen Kooi - Feb. 12, 2013, 5:15 p.m.
The kernel is loaded from an ext4 partition, not ext2 on beaglebone boards.

Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
---
 include/configs/am335x_evm.h | 1 +
 1 file changed, 1 insertion(+)
Peter Korsgaard - Feb. 17, 2013, 8:03 p.m.
>>>>> "Koen" == Koen Kooi <koen@dominion.thruhere.net> writes:

 Koen> The kernel is loaded from an ext4 partition, not ext2 on beaglebone boards.
 Koen> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
 Koen> ---
 Koen>  include/configs/am335x_evm.h | 1 +
 Koen>  1 file changed, 1 insertion(+)

 Koen> diff --git a/include/configs/am335x_evm.h b/include/configs/am335x_evm.h
 Koen> index 72459d8..2190a7d 100644
 Koen> --- a/include/configs/am335x_evm.h
 Koen> +++ b/include/configs/am335x_evm.h
 Koen> @@ -144,6 +144,7 @@
 Koen>  #define CONFIG_DOS_PARTITION
 Koen>  #define CONFIG_CMD_FAT
 Koen>  #define CONFIG_CMD_EXT2
 Koen> +#define CONFIG_CMD_EXT4

Shouldn't the bootcmd then also be changed to use ext4load instead? Why
keep CMD_EXT2 enabled?
Koen Kooi - Feb. 17, 2013, 10:50 p.m.
Op 17 feb. 2013 om 14:03 heeft Peter Korsgaard <jacmet@sunsite.dk> het volgende geschreven:

>>>>>> "Koen" == Koen Kooi <koen@dominion.thruhere.net> writes:
> 
> Koen> The kernel is loaded from an ext4 partition, not ext2 on beaglebone boards.
> Koen> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> Koen> ---
> Koen>  include/configs/am335x_evm.h | 1 +
> Koen>  1 file changed, 1 insertion(+)
> 
> Koen> diff --git a/include/configs/am335x_evm.h b/include/configs/am335x_evm.h
> Koen> index 72459d8..2190a7d 100644
> Koen> --- a/include/configs/am335x_evm.h
> Koen> +++ b/include/configs/am335x_evm.h
> Koen> @@ -144,6 +144,7 @@
> Koen>  #define CONFIG_DOS_PARTITION
> Koen>  #define CONFIG_CMD_FAT
> Koen>  #define CONFIG_CMD_EXT2
> Koen> +#define CONFIG_CMD_EXT4
> 
> Shouldn't the bootcmd then also be changed to use ext4load instead? Why
> keep CMD_EXT2 enabled?

that will be a followup patch

> 
> -- 
> Bye, Peter Korsgaard
Peter Korsgaard - Feb. 18, 2013, 6:26 a.m.
>>>>> "Koen" == Koen Kooi <koen@dominion.thruhere.net> writes:

 Koen> #define CONFIG_CMD_EXT2
 Koen> +#define CONFIG_CMD_EXT4
 >> 
 >> Shouldn't the bootcmd then also be changed to use ext4load instead? Why
 >> keep CMD_EXT2 enabled?

 Koen> that will be a followup patch

Ok. It imho makes sense to do both changes at once as they are strongly
related and in the same file.
Tom Rini - March 4, 2013, 8:08 p.m.
On Mon, Feb 18, 2013 at 07:26:42AM +0100, Peter Korsgaard wrote:
> >>>>> "Koen" == Koen Kooi <koen@dominion.thruhere.net> writes:
> 
>  Koen> #define CONFIG_CMD_EXT2
>  Koen> +#define CONFIG_CMD_EXT4
>  >> 
>  >> Shouldn't the bootcmd then also be changed to use ext4load instead? Why
>  >> keep CMD_EXT2 enabled?
> 
>  Koen> that will be a followup patch
> 
> Ok. It imho makes sense to do both changes at once as they are strongly
> related and in the same file.

And we ought to add CONFIG_CMD_FS_GENERIC and just 'load' so that this
can more easily work with folks still using FAT for boot.

Patch

diff --git a/include/configs/am335x_evm.h b/include/configs/am335x_evm.h
index 72459d8..2190a7d 100644
--- a/include/configs/am335x_evm.h
+++ b/include/configs/am335x_evm.h
@@ -144,6 +144,7 @@ 
 #define CONFIG_DOS_PARTITION
 #define CONFIG_CMD_FAT
 #define CONFIG_CMD_EXT2
+#define CONFIG_CMD_EXT4
 
 #define CONFIG_SPI
 #define CONFIG_OMAP3_SPI