| Submitter | Jiri Pirko |
|---|---|
| Date | Feb. 12, 2013, 10:12 a.m. |
| Message ID | <1360663929-1023-3-git-send-email-jiri@resnulli.us> |
| Download | mbox | patch |
| Permalink | /patch/219760/ |
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
Comments
From: Jiri Pirko <jiri@resnulli.us> Date: Tue, 12 Feb 2013 11:12:00 +0100 > in htb_change_class() cl->buffer and cl->buffer are stored in ns. > So in dump, convert them back to psched ticks. > > Note this was introduced by: > commit 56b765b79e9a78dc7d3f8850ba5e5567205a3ecd > htb: improved accuracy at high rates > > Please consider this for -net/-stable. > > Signed-off-by: Jiri Pirko <jiri@resnulli.us> > Acked-by: Eric Dumazet <edumazet@google.com> Applied to 'net' and queued up for -stable, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Patch
diff --git a/net/sched/sch_htb.c b/net/sched/sch_htb.c index 476992c..14a83dc 100644 --- a/net/sched/sch_htb.c +++ b/net/sched/sch_htb.c @@ -1135,9 +1135,9 @@ static int htb_dump_class(struct Qdisc *sch, unsigned long arg, memset(&opt, 0, sizeof(opt)); opt.rate.rate = cl->rate.rate_bps >> 3; - opt.buffer = cl->buffer; + opt.buffer = PSCHED_NS2TICKS(cl->buffer); opt.ceil.rate = cl->ceil.rate_bps >> 3; - opt.cbuffer = cl->cbuffer; + opt.cbuffer = PSCHED_NS2TICKS(cl->cbuffer); opt.quantum = cl->quantum; opt.prio = cl->prio; opt.level = cl->level;
in htb_change_class() cl->buffer and cl->buffer are stored in ns. So in dump, convert them back to psched ticks. Note this was introduced by: commit 56b765b79e9a78dc7d3f8850ba5e5567205a3ecd htb: improved accuracy at high rates Please consider this for -net/-stable. Signed-off-by: Jiri Pirko <jiri@resnulli.us> Acked-by: Eric Dumazet <edumazet@google.com> --- net/sched/sch_htb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)