Patchwork Disable libsanitizer before darwin10

login
register
mail settings
Submitter Jack Howarth
Date Feb. 11, 2013, 3:55 p.m.
Message ID <20130211155501.GA31314@bromo.med.uc.edu>
Download mbox | patch
Permalink /patch/219630/
State New
Headers show

Comments

Jack Howarth - Feb. 11, 2013, 3:55 p.m.
Iain Sandoe discovered that on intel darwin9, the asan testsuite suffers hundreds of 
failures due to the absence of dispatch calls (Grand Central Dispatch) prior to darwin10.
The attached patch disables building libsanitizer on darwin8 and darwin9 until upstream
decides to support the earlier darwin releases. Bootstrap and regression tested on
x86_64-apple-darwin12. Okay for gcc trunk?
         Jack
2013-02-11  Jack Howarth  <howarth@bromo.med.uc.edu>

	* configure.tgt: Disable build on darwin9 and earlier.

/libsanitizer
Alexander Potapenko - Feb. 11, 2013, 4:06 p.m.
For the record, ASan never claimed darwin9 support and isn't going to
support darwin9 in the future, so it should be fine to disable
building ASan on this platform.

On Mon, Feb 11, 2013 at 7:55 PM, Jack Howarth <howarth@bromo.med.uc.edu> wrote:
>   Iain Sandoe discovered that on intel darwin9, the asan testsuite suffers hundreds of
> failures due to the absence of dispatch calls (Grand Central Dispatch) prior to darwin10.
> The attached patch disables building libsanitizer on darwin8 and darwin9 until upstream
> decides to support the earlier darwin releases. Bootstrap and regression tested on
> x86_64-apple-darwin12. Okay for gcc trunk?
>          Jack



--
Alexander Potapenko
Software Engineer
Google Moscow
Mike Stump - Feb. 11, 2013, 11:16 p.m.
On Feb 11, 2013, at 7:55 AM, Jack Howarth <howarth@bromo.med.uc.edu> wrote:
>  Iain Sandoe discovered that on intel darwin9, the asan testsuite suffers hundreds of 
> failures due to the absence of dispatch calls (Grand Central Dispatch) prior to darwin10.
> The attached patch disables building libsanitizer on darwin8 and darwin9 until upstream
> decides to support the earlier darwin releases. Bootstrap and regression tested on
> x86_64-apple-darwin12. Okay for gcc trunk?

Ok.

Committed revision 195958.

If the patch needs to go upstream, could the asan people push it up?  Thanks.


I like fixing asan so that it works on darwin9.  If/when that is done, we can remove this patch; until such time, the patch is necessary.
Dmitriy Vyukov - Feb. 12, 2013, 6:17 a.m.
On Tue, Feb 12, 2013 at 3:16 AM, Mike Stump <mikestump@comcast.net> wrote:
> On Feb 11, 2013, at 7:55 AM, Jack Howarth <howarth@bromo.med.uc.edu> wrote:
>>  Iain Sandoe discovered that on intel darwin9, the asan testsuite suffers hundreds of
>> failures due to the absence of dispatch calls (Grand Central Dispatch) prior to darwin10.
>> The attached patch disables building libsanitizer on darwin8 and darwin9 until upstream
>> decides to support the earlier darwin releases. Bootstrap and regression tested on
>> x86_64-apple-darwin12. Okay for gcc trunk?
>
> Ok.
>
> Committed revision 195958.
>
> If the patch needs to go upstream, could the asan people push it up?  Thanks.
>
>
> I like fixing asan so that it works on darwin9.  If/when that is done, we can remove this patch; until such time, the patch is necessary.

LLVM uses different build system, so this patch can't be applied
directly. But future integrations won't break gcc.
Alexander, do we want to apply something similar upstream?

Patch

Index: libsanitizer/configure.tgt
===================================================================
--- libsanitizer/configure.tgt	(revision 195940)
+++ libsanitizer/configure.tgt	(working copy)
@@ -29,7 +29,7 @@  case "${target}" in
 	;;
   sparc*-*-linux*)
 	;;
-  x86_64-*-darwin* | i?86-*-darwin*)
+  x86_64-*-darwin[1]* | i?86-*-darwin[1]*)
 	TSAN_SUPPORTED=no
 	;;
   *)