Patchwork [1/3] ARM: mxs: mm: Fix sparse warning

login
register
mail settings
Submitter Fabio Estevam
Date Feb. 11, 2013, 2:01 p.m.
Message ID <1360591308-7482-1-git-send-email-festevam@gmail.com>
Download mbox | patch
Permalink /patch/219611/
State New
Headers show

Comments

Fabio Estevam - Feb. 11, 2013, 2:01 p.m.
From: Fabio Estevam <fabio.estevam@freescale.com>

Include <mach/common.h> header to fix the following sparse warnings:

arch/arm/mach-mxs/mm.c:43:13: warning: symbol 'mx23_map_io' was not declared. Should it be static?
arch/arm/mach-mxs/mm.c:48:13: warning: symbol 'mx28_map_io' was not declared. Should it be static?

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/mach-mxs/mm.c |    1 +
 1 file changed, 1 insertion(+)
Shawn Guo - Feb. 17, 2013, 8:01 a.m.
On Mon, Feb 11, 2013 at 12:01:46PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Include <mach/common.h> header to fix the following sparse warnings:
> 
> arch/arm/mach-mxs/mm.c:43:13: warning: symbol 'mx23_map_io' was not declared. Should it be static?
> arch/arm/mach-mxs/mm.c:48:13: warning: symbol 'mx28_map_io' was not declared. Should it be static?
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Queued all 3 for 3.10, as I do not categorize them as critical fixes.

Shawn

> ---
>  arch/arm/mach-mxs/mm.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-mxs/mm.c b/arch/arm/mach-mxs/mm.c
> index a4294aa..e63b7d8 100644
> --- a/arch/arm/mach-mxs/mm.c
> +++ b/arch/arm/mach-mxs/mm.c
> @@ -18,6 +18,7 @@
>  
>  #include <mach/mx23.h>
>  #include <mach/mx28.h>
> +#include <mach/common.h>
>  
>  /*
>   * Define the MX23 memory map.
> -- 
> 1.7.9.5
>

Patch

diff --git a/arch/arm/mach-mxs/mm.c b/arch/arm/mach-mxs/mm.c
index a4294aa..e63b7d8 100644
--- a/arch/arm/mach-mxs/mm.c
+++ b/arch/arm/mach-mxs/mm.c
@@ -18,6 +18,7 @@ 
 
 #include <mach/mx23.h>
 #include <mach/mx28.h>
+#include <mach/common.h>
 
 /*
  * Define the MX23 memory map.