From patchwork Sun Feb 10 10:52:11 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Pirko X-Patchwork-Id: 219478 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id F1BE72C0099 for ; Sun, 10 Feb 2013 21:52:52 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754649Ab3BJKwu (ORCPT ); Sun, 10 Feb 2013 05:52:50 -0500 Received: from mail-ee0-f47.google.com ([74.125.83.47]:57808 "EHLO mail-ee0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754323Ab3BJKwr (ORCPT ); Sun, 10 Feb 2013 05:52:47 -0500 Received: by mail-ee0-f47.google.com with SMTP id e52so2678749eek.20 for ; Sun, 10 Feb 2013 02:52:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:x-gm-message-state; bh=eDxSdEh/8Fpbve1Eagd4qMsF2v51O5l5P5go+7uc+s8=; b=FsYbX0FzHXguWpHyrv6Sn1RzDlAT+Kycbp0tHz0qe3Vi/QhnBW0UomgDtUag0IzzKV esnzXA3WdGf5xmo6hH7ENizElEqVM4ilCC5BCFd/T5YJvJPoFg2Kc67Jm2QcD0v06SSd otaCkWJA8Zm4eKiE6MIqIKtD6e4/cnKOJeH1bHtvtGNzFkaf2UGbEYm48yFZqT0yZb9m lJjP2BymiMpYWFxM0MM4NdCIlvpJB94uel+EyD4V35oeiPn4to4kxZANgprM4Q6qgjqm 2wJzaGdt6lENvvjhl01GfGteQzS0PIlm8QHPI0jfspx65iPZ/WIAn6jKF/vQaVzKyjG3 gEGQ== X-Received: by 10.14.224.137 with SMTP id x9mr37515735eep.11.1360493566422; Sun, 10 Feb 2013 02:52:46 -0800 (PST) Received: from localhost (sun-0.pirko.cz. [84.16.102.25]) by mx.google.com with ESMTPS id o3sm56623135eem.15.2013.02.10.02.52.45 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 10 Feb 2013 02:52:45 -0800 (PST) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, jhs@mojatatu.com, kuznet@ms2.inr.ac.ru, j.vimal@gmail.com Subject: [patch net-next v4 03/11] htb: remove pointless first initialization of buffer and cbuffer Date: Sun, 10 Feb 2013 11:52:11 +0100 Message-Id: <1360493539-14868-4-git-send-email-jiri@resnulli.us> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1360493539-14868-1-git-send-email-jiri@resnulli.us> References: <1360493539-14868-1-git-send-email-jiri@resnulli.us> X-Gm-Message-State: ALoCoQlUDttq3Q2/g+U6MPrqlKsgoIdscKAcH1yrZ2F25nfpVNB5xv6u737xEUBpKzXY4mLa1lD2 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org these are initialized correctly couple of lines later in the function. Signed-off-by: Jiri Pirko Acked-by: Eric Dumazet --- net/sched/sch_htb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/sched/sch_htb.c b/net/sched/sch_htb.c index 14a83dc..547912e9 100644 --- a/net/sched/sch_htb.c +++ b/net/sched/sch_htb.c @@ -1503,9 +1503,6 @@ static int htb_change_class(struct Qdisc *sch, u32 classid, cl->prio = TC_HTB_NUMPRIO - 1; } - cl->buffer = hopt->buffer; - cl->cbuffer = hopt->cbuffer; - cl->rate.rate_bps = (u64)hopt->rate.rate << 3; cl->ceil.rate_bps = (u64)hopt->ceil.rate << 3;