Patchwork [1/1] libtirpc: requires toolchain with threads support

login
register
mail settings
Submitter gilles.talis@gmail.com
Date Feb. 9, 2013, 10:27 p.m.
Message ID <1360448834-21507-1-git-send-email-gilles.talis@gmail.com>
Download mbox | patch
Permalink /patch/219462/
State Changes Requested
Headers show

Comments

gilles.talis@gmail.com - Feb. 9, 2013, 10:27 p.m.
Fixes:
http://autobuild.buildroot.org/results/8ba720f47f74df94b8c70ac4befd47c47ce65f2f

Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
---
 package/libtirpc/Config.in |    4 ++++
 1 file changed, 4 insertions(+)
Peter Korsgaard - Feb. 10, 2013, 10:02 a.m.
>>>>> "Gilles" == Gilles Talis <gilles.talis@gmail.com> writes:

 Gilles> Fixes:
 Gilles> http://autobuild.buildroot.org/results/8ba720f47f74df94b8c70ac4befd47c47ce65f2f

 Gilles> Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
 Gilles> ---
 Gilles>  package/libtirpc/Config.in |    4 ++++
 Gilles>  1 file changed, 4 insertions(+)

 Gilles> diff --git a/package/libtirpc/Config.in b/package/libtirpc/Config.in
 Gilles> index 7e891b4..f2a6f83 100644
 Gilles> --- a/package/libtirpc/Config.in
 Gilles> +++ b/package/libtirpc/Config.in
 Gilles> @@ -1,7 +1,11 @@
 Gilles>  config BR2_PACKAGE_LIBTIRPC
 Gilles>  	bool "libtirpc"
 Gilles> +	depends on BR2_TOOLCHAIN_HAS_THREADS

Thanks, but you also need to propagate this dependency to libtirpc's
reverse dependencies:

git grep -l 'select BR2_PACKAGE_LIBTIRPC'
package/conntrack-tools/Config.in
package/lmbench/Config.in
package/nfs-utils/Config.in
package/quota/Config.in
package/rpcbind/Config.in

Care to fix that up and resend?
gilles.talis@gmail.com - Feb. 10, 2013, 5:54 p.m.
Good point.
Will fix and resend.
Gilles.

2013/2/10 Peter Korsgaard <jacmet@uclibc.org>

> >>>>> "Gilles" == Gilles Talis <gilles.talis@gmail.com> writes:
>
>  Gilles> Fixes:
>  Gilles>
> http://autobuild.buildroot.org/results/8ba720f47f74df94b8c70ac4befd47c47ce65f2f
>
>  Gilles> Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
>  Gilles> ---
>  Gilles>  package/libtirpc/Config.in |    4 ++++
>  Gilles>  1 file changed, 4 insertions(+)
>
>  Gilles> diff --git a/package/libtirpc/Config.in
> b/package/libtirpc/Config.in
>  Gilles> index 7e891b4..f2a6f83 100644
>  Gilles> --- a/package/libtirpc/Config.in
>  Gilles> +++ b/package/libtirpc/Config.in
>  Gilles> @@ -1,7 +1,11 @@
>  Gilles>  config BR2_PACKAGE_LIBTIRPC
>  Gilles>        bool "libtirpc"
>  Gilles> +      depends on BR2_TOOLCHAIN_HAS_THREADS
>
> Thanks, but you also need to propagate this dependency to libtirpc's
> reverse dependencies:
>
> git grep -l 'select BR2_PACKAGE_LIBTIRPC'
> package/conntrack-tools/Config.in
> package/lmbench/Config.in
> package/nfs-utils/Config.in
> package/quota/Config.in
> package/rpcbind/Config.in
>
> Care to fix that up and resend?
>
> --
> Bye, Peter Korsgaard
>
Thomas Petazzoni - Feb. 11, 2013, 8:18 a.m.
Dear Gilles Talis,

On Sat,  9 Feb 2013 14:27:14 -0800, Gilles Talis wrote:
> Fixes:
> http://autobuild.buildroot.org/results/8ba720f47f74df94b8c70ac4befd47c47ce65f2f
> 
> Signed-off-by: Gilles Talis <gilles.talis@gmail.com>

I believe libtirpc pthread usage could be made optional, and that would
probably be an useful contribution upstream, and avoid us from having
to add this toolchain dependency.

Best regards,

Thomas
Samuel Martin - May 16, 2013, 7:02 p.m.
Hi Thomas, all,

2013/2/11 Thomas Petazzoni <thomas.petazzoni@free-electrons.com>:
> Dear Gilles Talis,
>
> On Sat,  9 Feb 2013 14:27:14 -0800, Gilles Talis wrote:
>> Fixes:
>> http://autobuild.buildroot.org/results/8ba720f47f74df94b8c70ac4befd47c47ce65f2f
>>
>> Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
>
> I believe libtirpc pthread usage could be made optional, and that would
> probably be an useful contribution upstream, and avoid us from having
> to add this toolchain dependency.

Some of the recent libtirpc build failures are also caused by this.

Looking at the source, it seems that's a bug the AC_CHECK_LIB call that does not
do anything when pthead is not found; though it unconditionally
include pthread.h
in many source files, and does not use at all the HAVE_LIBPTHREAD symbol.

Regards,
Samuel Martin - Aug. 30, 2013, 6:41 a.m.
Ping?

This patch should fix the following autobuilder failures:
       arm |                 libtirpc-0.2.2 | NOK |
http://autobuild.buildroot.net/results/446d49bcf2b139ccc495d867d898673969823148/
       arm |                 libtirpc-0.2.2 | NOK |
http://autobuild.buildroot.net/results/4d84dfd309d313c8d0248d33bdee43bc7bbfa187/

Regards,

Patch

diff --git a/package/libtirpc/Config.in b/package/libtirpc/Config.in
index 7e891b4..f2a6f83 100644
--- a/package/libtirpc/Config.in
+++ b/package/libtirpc/Config.in
@@ -1,7 +1,11 @@ 
 config BR2_PACKAGE_LIBTIRPC
 	bool "libtirpc"
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
 	  Libtirpc is a port of Sun's Transport-Independent RPC
 	  library to Linux.
 
 	  http://sourceforge.net/projects/libtirpc/
+
+comment "libtirpc requires a toolchain with threads support"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS