Patchwork [U-Boot,v5,23/23] tegra: Enable generic board for Seaboard.

login
register
mail settings
Submitter Simon Glass
Date Feb. 8, 2013, 3:12 p.m.
Message ID <1360336339-10703-24-git-send-email-sjg@chromium.org>
Download mbox | patch
Permalink /patch/219180/
State Superseded, archived
Delegated to: Tom Warren
Headers show

Comments

Simon Glass - Feb. 8, 2013, 3:12 p.m.
Enable CONFIG_SYS_GENERIC_BOARD for Tegra 2 Seaboard.

Signed-off-by: Simon Glass <sjg@chromium.org>
---
Changes in v5: None
Changes in v4:
- Rebase to master
- Drop sc520_timer.c patch (warning already fixed by previous patch)

Changes in v3:
- Rebase to master
- Rebase on top of x86/master (which has not yet been pulled to master)

Changes in v2:
- Change generic board to an opt-in system on a per-board basic
- Add CONFIG_SYS_GENERIC_BOARD to allow board to select generic board
- Add PowerPC support
- Rebase to master

 include/configs/seaboard.h | 2 ++
 1 file changed, 2 insertions(+)
Stephen Warren - Feb. 8, 2013, 5:23 p.m.
On 02/08/2013 08:12 AM, Simon Glass wrote:
> Enable CONFIG_SYS_GENERIC_BOARD for Tegra 2 Seaboard.

Shouldn't this be enabled for Tegra generically, rather than for just
one Tegra board? I haven't looked at the rest of the series yet, but it
sure seems better if all Tegra boards always work the same way.
Simon Glass - Feb. 8, 2013, 6:10 p.m.
Hi Stephen

On Fri, Feb 8, 2013 at 9:23 AM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 02/08/2013 08:12 AM, Simon Glass wrote:
>> Enable CONFIG_SYS_GENERIC_BOARD for Tegra 2 Seaboard.
>
> Shouldn't this be enabled for Tegra generically, rather than for just
> one Tegra board? I haven't looked at the rest of the series yet, but it
> sure seems better if all Tegra boards always work the same way.

Yes but I can only test on that board. I suspect it should be OK with
others but I've taken a fairly conservative approach as I don't want
to break things.

If you have a board about, please try putting it in tegra-common.h or
similar and see what happens.

BTW it would be nice to have a tegra20-dt.h config. Then I would just
test that one board and know that other changes can only be
FDT-related. But I think due to pinmux that isn't possible right now,
as previously discussed.

Regards,
Simon
Stephen Warren - Feb. 8, 2013, 7:12 p.m.
On 02/08/2013 11:10 AM, Simon Glass wrote:
> Hi Stephen
> 
> On Fri, Feb 8, 2013 at 9:23 AM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> On 02/08/2013 08:12 AM, Simon Glass wrote:
>>> Enable CONFIG_SYS_GENERIC_BOARD for Tegra 2 Seaboard.
>>
>> Shouldn't this be enabled for Tegra generically, rather than for just
>> one Tegra board? I haven't looked at the rest of the series yet, but it
>> sure seems better if all Tegra boards always work the same way.
> 
> Yes but I can only test on that board. I suspect it should be OK with
> others but I've taken a fairly conservative approach as I don't want
> to break things.
> 
> If you have a board about, please try putting it in tegra-common.h or
> similar and see what happens.

This is something Tom should drive.

> BTW it would be nice to have a tegra20-dt.h config. Then I would just
> test that one board and know that other changes can only be
> FDT-related. But I think due to pinmux that isn't possible right now,
> as previously discussed.

Well, there are quite a few peripherals which are only
initialized/instantiated from board files too, so a generic DT config
wouldn't be very useful yet, although Tom and Allen are in the process
of converting things as they add Tegra114 support.

Patch

diff --git a/include/configs/seaboard.h b/include/configs/seaboard.h
index de0c777..0d2a318 100644
--- a/include/configs/seaboard.h
+++ b/include/configs/seaboard.h
@@ -40,6 +40,8 @@ 
 #define CONFIG_OF_CONTROL
 #define CONFIG_OF_SEPARATE
 
+#define CONFIG_SYS_GENERIC_BOARD
+
 /* High-level configuration options */
 #define V_PROMPT		"Tegra20 (SeaBoard) # "
 #define CONFIG_TEGRA_BOARD_STRING	"NVIDIA Seaboard"