From patchwork Fri Feb 8 12:15:45 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Armbruster X-Patchwork-Id: 219125 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 150822C0086 for ; Fri, 8 Feb 2013 23:16:17 +1100 (EST) Received: from localhost ([::1]:50748 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U3msI-0000Ol-UH for incoming@patchwork.ozlabs.org; Fri, 08 Feb 2013 07:16:14 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33262) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U3mrx-0000O3-U3 for qemu-devel@nongnu.org; Fri, 08 Feb 2013 07:15:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U3mrw-0007AF-SV for qemu-devel@nongnu.org; Fri, 08 Feb 2013 07:15:53 -0500 Received: from oxygen.pond.sub.org ([2a01:4f8:121:10e4::3]:38997) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U3mrw-00079l-Lx; Fri, 08 Feb 2013 07:15:52 -0500 Received: from blackfin.pond.sub.org (p5B32B25A.dip.t-dialin.net [91.50.178.90]) by oxygen.pond.sub.org (Postfix) with ESMTPA id 3120B9FE7B; Fri, 8 Feb 2013 13:15:49 +0100 (CET) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 54C80200A9; Fri, 8 Feb 2013 13:15:49 +0100 (CET) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Fri, 8 Feb 2013 13:15:45 +0100 Message-Id: <1360325749-1989-3-git-send-email-armbru@redhat.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1360325749-1989-1-git-send-email-armbru@redhat.com> References: <1360325749-1989-1-git-send-email-armbru@redhat.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a01:4f8:121:10e4::3 Cc: qemu-trivial@nongnu.org Subject: [Qemu-devel] [PATCH for-1.4 2/6] error: Clean up abuse of error_report() for help X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Use error_printf() instead, so the help gets presented more nicely. Signed-off-by: Markus Armbruster --- hw/vfio_pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/vfio_pci.c b/hw/vfio_pci.c index 66537b7..a934f13 100644 --- a/hw/vfio_pci.c +++ b/hw/vfio_pci.c @@ -1806,9 +1806,9 @@ static int vfio_get_device(VFIOGroup *group, const char *name, VFIODevice *vdev) ret = ioctl(group->fd, VFIO_GROUP_GET_DEVICE_FD, name); if (ret < 0) { - error_report("vfio: error getting device %s from group %d: %m\n", + error_report("vfio: error getting device %s from group %d: %m", name, group->groupid); - error_report("Verify all devices in group %d are bound to vfio-pci " + error_printf("Verify all devices in group %d are bound to vfio-pci " "or pci-stub and not already in use\n", group->groupid); return ret; }