Patchwork [U-Boot,2/3] led: The gpio_led.c code expects that LED state is from the enum

login
register
mail settings
Submitter Holger Hans Peter Freyther
Date Feb. 8, 2013, 9:41 a.m.
Message ID <1360316463-5061-2-git-send-email-holger@freyther.de>
Download mbox | patch
Permalink /patch/219076/
State Accepted
Delegated to: Tom Rini
Headers show

Comments

Holger Hans Peter Freyther - Feb. 8, 2013, 9:41 a.m.
u-boot is not consistent if state should be 0|1 or of the enum, the
GPIO driver expects this to be one of the enum values. Update the
caller.

Signed-off-by: Holger Hans Peter Freyther <holger@freyther.de>
---
 common/cmd_led.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Otavio Salvador - Feb. 8, 2013, 11:52 a.m.
On Fri, Feb 8, 2013 at 7:41 AM, Holger Hans Peter Freyther
<holger@freyther.de> wrote:
> u-boot is not consistent if state should be 0|1 or of the enum, the
> GPIO driver expects this to be one of the enum values. Update the
> caller.
>
> Signed-off-by: Holger Hans Peter Freyther <holger@freyther.de>

I sent same fix some days ago. ;-)

Patch

diff --git a/common/cmd_led.c b/common/cmd_led.c
index 7f5ab43..c725f95 100644
--- a/common/cmd_led.c
+++ b/common/cmd_led.c
@@ -110,13 +110,13 @@  int do_led (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 				if (led_commands[i].on)
 					led_commands[i].on();
 				else
-					__led_set(led_commands[i].mask, 1);
+					__led_set(led_commands[i].mask, STATUS_LED_ON);
 				break;
 			case LED_OFF:
 				if (led_commands[i].off)
 					led_commands[i].off();
 				else
-					__led_set(led_commands[i].mask, 0);
+					__led_set(led_commands[i].mask, STATUS_LED_OFF);
 				break;
 			case LED_TOGGLE:
 				if (led_commands[i].toggle)