Message ID | 1360249074-2642-2-git-send-email-wangshilong1991@gmail.com |
---|---|
State | Not Applicable, archived |
Headers | show |
On Thu 07-02-13 22:57:54, Wang shilong wrote: > From: Wang Shilong <wangsl-fnst@cn.fujitsu.com> > > Because the static function 'release_blocks' is only called > when releasing blocks,it will be more simple and efficient to > call the function 'percpu_counter_add' directly. Thanks. I've added the patch to my tree. Honza > > Signed-off-by: Wang Shilong <wangsl-fnst@cn.fujitsu.com> > --- > fs/ext2/balloc.c | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c > index 9d372bf..d5a6afd 100644 > --- a/fs/ext2/balloc.c > +++ b/fs/ext2/balloc.c > @@ -159,15 +159,6 @@ read_block_bitmap(struct super_block *sb, unsigned int block_group) > return bh; > } > > -static void release_blocks(struct super_block *sb, int count) > -{ > - if (count) { > - struct ext2_sb_info *sbi = EXT2_SB(sb); > - > - percpu_counter_add(&sbi->s_freeblocks_counter, count); > - } > -} > - > static void group_adjust_blocks(struct super_block *sb, int group_no, > struct ext2_group_desc *desc, struct buffer_head *bh, int count) > { > @@ -569,7 +560,7 @@ do_more: > error_return: > brelse(bitmap_bh); > if (freed) { > - release_blocks(sb, freed); > + percpu_counter_add(&sbi->s_freeblocks_counter, freed); > dquot_free_block_nodirty(inode, freed); > mark_inode_dirty(inode); > } > -- > 1.7.11.7 >
diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c index 9d372bf..d5a6afd 100644 --- a/fs/ext2/balloc.c +++ b/fs/ext2/balloc.c @@ -159,15 +159,6 @@ read_block_bitmap(struct super_block *sb, unsigned int block_group) return bh; } -static void release_blocks(struct super_block *sb, int count) -{ - if (count) { - struct ext2_sb_info *sbi = EXT2_SB(sb); - - percpu_counter_add(&sbi->s_freeblocks_counter, count); - } -} - static void group_adjust_blocks(struct super_block *sb, int group_no, struct ext2_group_desc *desc, struct buffer_head *bh, int count) { @@ -569,7 +560,7 @@ do_more: error_return: brelse(bitmap_bh); if (freed) { - release_blocks(sb, freed); + percpu_counter_add(&sbi->s_freeblocks_counter, freed); dquot_free_block_nodirty(inode, freed); mark_inode_dirty(inode); }