From patchwork Thu Feb 7 10:55:37 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [net,2/2] net: sctp: sctp_auth_key_put: use kzfree instead of kfree Date: Thu, 07 Feb 2013 00:55:37 -0000 From: Daniel Borkmann X-Patchwork-Id: 218890 Message-Id: <8c764d916f21d56402a5b9a915ea31d927898da0.1360231701.git.dborkman@redhat.com> To: vyasevich@gmail.com Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-sctp@vger.kernel.org For sensitive data like keying material, it is common practice to zero out keys before returning the memory back to the allocator. Thus, use kzfree instead of kfree. Signed-off-by: Daniel Borkmann Acked-by: Vlad Yasevich --- net/sctp/auth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sctp/auth.c b/net/sctp/auth.c index 55f1b06..69fcd6d 100644 --- a/net/sctp/auth.c +++ b/net/sctp/auth.c @@ -71,7 +71,7 @@ void sctp_auth_key_put(struct sctp_auth_bytes *key) return; if (atomic_dec_and_test(&key->refcnt)) { - kfree(key); + kzfree(key); SCTP_DBG_OBJCNT_DEC(keys); } }