Patchwork [U-Boot,U-boot,PATCHv2,2/3] OMAP3: igep00x0: add missing include mach-types.h

login
register
mail settings
Submitter Enric Balletbò i Serra
Date Feb. 7, 2013, 10:40 a.m.
Message ID <1360233606-26806-3-git-send-email-eballetbo@iseebcn.com>
Download mbox | patch
Permalink /patch/218887/
State Accepted
Delegated to: Tom Rini
Headers show

Comments

Enric Balletbò i Serra - Feb. 7, 2013, 10:40 a.m.
From: Enric Balletbo i Serra <eballetbo@iseebcn.com>

Current '#if' directives (used in igep00x0.h config file) comparing MACH_TYPE
values in igep00x0.h doesn't work as expected. The comparision between
CONFIG_MACH_TYPE and MACH_TYPE_IGEP0020 is always true independent of the IGEP
machine configured.

For example, following directive

 if (CONFIG_MACH_TYPE == MACH_TYPE_IGEP0020)
    define something
 endif

Is always evaluated true although we configure u-boot for MACH_TYPE_IGEP0030.

The build doesn't shows any error so looks that both defines had always the same
value. Including the mach-types.h file sets properly the value of
MACH_TYPE_IGEPxxxx.

Signed-off-by: Enric Balletbo i Serra <eballetbo@iseebcn.com>
---
 include/configs/igep00x0.h |    1 +
 1 file changed, 1 insertion(+)

Patch

diff --git a/include/configs/igep00x0.h b/include/configs/igep00x0.h
index 0e7f924..0e539ef 100644
--- a/include/configs/igep00x0.h
+++ b/include/configs/igep00x0.h
@@ -36,6 +36,7 @@ 
 
 #include <asm/arch/cpu.h>
 #include <asm/arch/omap3.h>
+#include <asm/mach-types.h>
 
 /*
  * Display CPU and Board information