From patchwork Thu Feb 7 10:14:38 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [V2] bgmac: validate MAC addr From: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= X-Patchwork-Id: 218876 Message-Id: <1360232078-21872-1-git-send-email-zajec5@gmail.com> To: netdev@vger.kernel.org, "David S. Miller" Cc: Florian Fainelli , =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= Date: Thu, 7 Feb 2013 11:14:38 +0100 Signed-off-by: Rafał Miłecki --- V2: generate random addr --- drivers/net/ethernet/broadcom/bgmac.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c index d08a4af..f90d1dc 100644 --- a/drivers/net/ethernet/broadcom/bgmac.c +++ b/drivers/net/ethernet/broadcom/bgmac.c @@ -1318,6 +1318,12 @@ static int bgmac_probe(struct bcma_device *core) return -ENOTSUPP; } + if (!is_valid_ether_addr(mac)) { + dev_err(&core->dev, "Invalid MAC addr: %pM\n", mac); + eth_random_addr(mac); + dev_warn(&core->dev, "Using random MAC: %pM\n", mac); + } + /* Allocation and references */ net_dev = alloc_etherdev(sizeof(*bgmac)); if (!net_dev)