Patchwork [U-Boot] SPI: Winbond: Add W25Q32 to spi flash table

login
register
mail settings
Submitter Rajeshwari Birje
Date Feb. 7, 2013, 10:07 a.m.
Message ID <1360231637-20682-1-git-send-email-rajeshwari.s@samsung.com>
Download mbox | patch
Permalink /patch/218874/
State Rejected
Delegated to: Jagannadha Sutradharudu Teki
Headers show

Comments

Rajeshwari Birje - Feb. 7, 2013, 10:07 a.m.
Add W25Q32 to Winbond spi flash table as it is required for snow

Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
---
 drivers/mtd/spi/winbond.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
Simon Glass - Feb. 8, 2013, 4:26 a.m.
On Thu, Feb 7, 2013 at 2:07 AM, Rajeshwari Shinde
<rajeshwari.s@samsung.com> wrote:
> Add W25Q32 to Winbond spi flash table as it is required for snow
>
> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>

Acked-by: Simon Glass <sjg@chromium.org>

> ---
>  drivers/mtd/spi/winbond.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mtd/spi/winbond.c b/drivers/mtd/spi/winbond.c
> index f6aab3d..f47634e 100644
> --- a/drivers/mtd/spi/winbond.c
> +++ b/drivers/mtd/spi/winbond.c
> @@ -67,6 +67,11 @@ static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
>                 .nr_blocks              = 128,
>                 .name                   = "W25Q80",
>         },
> +       {
> +               .id                     = 0x6016,
> +               .nr_blocks              = 64,
> +               .name                   = "W25Q32",
> +       },
>  };
>
>  struct spi_flash *spi_flash_probe_winbond(struct spi_slave *spi, u8 *idcode)
> --
> 1.7.4.4
>
Rajeshwari Birje - March 22, 2013, 6:21 a.m.
Hi Minkyu Kang,

Please let me know if we can merge this into u-boot-samsung branch or
do I need to re-base on some other branch.

Regards,
Rajeshwari Shinde

On Fri, Feb 8, 2013 at 9:56 AM, Simon Glass <sjg@chromium.org> wrote:
> On Thu, Feb 7, 2013 at 2:07 AM, Rajeshwari Shinde
> <rajeshwari.s@samsung.com> wrote:
>> Add W25Q32 to Winbond spi flash table as it is required for snow
>>
>> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
>
> Acked-by: Simon Glass <sjg@chromium.org>
>
>> ---
>>  drivers/mtd/spi/winbond.c |    5 +++++
>>  1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/mtd/spi/winbond.c b/drivers/mtd/spi/winbond.c
>> index f6aab3d..f47634e 100644
>> --- a/drivers/mtd/spi/winbond.c
>> +++ b/drivers/mtd/spi/winbond.c
>> @@ -67,6 +67,11 @@ static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
>>                 .nr_blocks              = 128,
>>                 .name                   = "W25Q80",
>>         },
>> +       {
>> +               .id                     = 0x6016,
>> +               .nr_blocks              = 64,
>> +               .name                   = "W25Q32",
>> +       },
>>  };
>>
>>  struct spi_flash *spi_flash_probe_winbond(struct spi_slave *spi, u8 *idcode)
>> --
>> 1.7.4.4
>>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
Jagannadha Sutradharudu Teki - May 23, 2013, 7:43 a.m.
Hi Rajeshwari,

On Fri, Mar 22, 2013 at 11:51 AM, Rajeshwari Birje
<rajeshwari.birje@gmail.com> wrote:
> Hi Minkyu Kang,
>
> Please let me know if we can merge this into u-boot-samsung branch or
> do I need to re-base on some other branch.
>
> Regards,
> Rajeshwari Shinde
>
> On Fri, Feb 8, 2013 at 9:56 AM, Simon Glass <sjg@chromium.org> wrote:
>> On Thu, Feb 7, 2013 at 2:07 AM, Rajeshwari Shinde
>> <rajeshwari.s@samsung.com> wrote:
>>> Add W25Q32 to Winbond spi flash table as it is required for snow
>>>
>>> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
>>
>> Acked-by: Simon Glass <sjg@chromium.org>
>>
>>> ---
>>>  drivers/mtd/spi/winbond.c |    5 +++++
>>>  1 files changed, 5 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/mtd/spi/winbond.c b/drivers/mtd/spi/winbond.c
>>> index f6aab3d..f47634e 100644
>>> --- a/drivers/mtd/spi/winbond.c
>>> +++ b/drivers/mtd/spi/winbond.c
>>> @@ -67,6 +67,11 @@ static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
>>>                 .nr_blocks              = 128,
>>>                 .name                   = "W25Q80",
>>>         },
>>> +       {
>>> +               .id                     = 0x6016,
>>> +               .nr_blocks              = 64,
>>> +               .name                   = "W25Q32",
>>> +       },
>>>  };
>>>

Can you please check that the same part support has been added already in master
http://git.denx.de/?p=u-boot/u-boot-spi.git;a=commitdiff;h=772ba15474f73adc942e817cc072b6e9750836cc

Please let me know you are referring a different part.
And also the change in above link seems to have incorrect nr_blocks, i
will write a mail CC you as well.

Thanks,
Jagan.

Patch

diff --git a/drivers/mtd/spi/winbond.c b/drivers/mtd/spi/winbond.c
index f6aab3d..f47634e 100644
--- a/drivers/mtd/spi/winbond.c
+++ b/drivers/mtd/spi/winbond.c
@@ -67,6 +67,11 @@  static const struct winbond_spi_flash_params winbond_spi_flash_table[] = {
 		.nr_blocks		= 128,
 		.name			= "W25Q80",
 	},
+	{
+		.id			= 0x6016,
+		.nr_blocks		= 64,
+		.name			= "W25Q32",
+	},
 };
 
 struct spi_flash *spi_flash_probe_winbond(struct spi_slave *spi, u8 *idcode)