From patchwork Wed Feb 6 20:27:18 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [for-1.4, v2, 05/13] qmp: Plug memory leaks in memchar-write, memchar-read Date: Wed, 06 Feb 2013 10:27:18 -0000 From: Markus Armbruster X-Patchwork-Id: 218756 Message-Id: <1360182446-1502-6-git-send-email-armbru@redhat.com> To: qemu-devel@nongnu.org Cc: lilei@linux.vnet.ibm.com, lcapitulino@redhat.com Signed-off-by: Markus Armbruster --- qemu-char.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/qemu-char.c b/qemu-char.c index b1c6132..4dd01e6 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2782,6 +2782,10 @@ void qmp_memchar_write(const char *device, const char *data, ret = cirmem_chr_write(chr, write_data, write_count); + if (write_data != (uint8_t *)data) { + g_free((void *)write_data); + } + if (ret < 0) { error_setg(errp, "Failed to write to device %s", device); return; @@ -2825,6 +2829,7 @@ char *qmp_memchar_read(const char *device, int64_t size, if (has_format && (format == DATA_FORMAT_BASE64)) { data = g_base64_encode(read_data, size); + g_free(read_data); } else { data = (char *)read_data; }