Patchwork [for-1.4,v2,05/13] qmp: Plug memory leaks in memchar-write, memchar-read

login
register
mail settings
Submitter Markus Armbruster
Date Feb. 6, 2013, 8:27 p.m.
Message ID <1360182446-1502-6-git-send-email-armbru@redhat.com>
Download mbox | patch
Permalink /patch/218756/
State New
Headers show

Comments

Markus Armbruster - Feb. 6, 2013, 8:27 p.m.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 qemu-char.c | 5 +++++
 1 file changed, 5 insertions(+)

Patch

diff --git a/qemu-char.c b/qemu-char.c
index b1c6132..4dd01e6 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2782,6 +2782,10 @@  void qmp_memchar_write(const char *device, const char *data,
 
     ret = cirmem_chr_write(chr, write_data, write_count);
 
+    if (write_data != (uint8_t *)data) {
+        g_free((void *)write_data);
+    }
+
     if (ret < 0) {
         error_setg(errp, "Failed to write to device %s", device);
         return;
@@ -2825,6 +2829,7 @@  char *qmp_memchar_read(const char *device, int64_t size,
 
     if (has_format && (format == DATA_FORMAT_BASE64)) {
         data = g_base64_encode(read_data, size);
+        g_free(read_data);
     } else {
         data = (char *)read_data;
     }