From patchwork Wed Feb 6 16:37:12 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Marlier X-Patchwork-Id: 218690 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 564332C007B for ; Thu, 7 Feb 2013 03:38:13 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1360773493; h=Comment: DomainKey-Signature:Received:Received:Received:Received: MIME-Version:Received:In-Reply-To:References:Date:Message-ID: Subject:From:To:Cc:Content-Type:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=D0T3iB20OhcdxhSllpDd8CVWjgw=; b=Q8sRsQE119Z0DhQ W/GH4B8uO1nSx8O66rv1fqnymHF/OLupCzssYqKWH1gj/44pStfDuQ0z557cl6Pg pZSxXmXXzQepA9RVh9JBmk2YunRDjWrTIybIdn1HPBg/tJ+WOUTyQX7mhX9CmmPy Q9OAkdnf3k1JCi8U8djlk+shhZWo= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:MIME-Version:X-Received:Received:In-Reply-To:References:Date:Message-ID:Subject:From:To:Cc:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=J+G1RYroyfbdo2psZHwyxul9NS5WlwlpWaMphdDWlu4OpNrx/4k+gGay/aalSy VauZg6WaIdFMFpVcYFACU0tkd0KDb3lPrUShgHHeL9THEbkQ6Oau5rNhNrQPYfGX 25aU3sh3jz0NGaBnZqKRsfUP2PSzZANLg2pJopMu/SpOM=; Received: (qmail 31865 invoked by alias); 6 Feb 2013 16:37:31 -0000 Received: (qmail 31612 invoked by uid 22791); 6 Feb 2013 16:37:26 -0000 X-SWARE-Spam-Status: No, hits=-5.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, KHOP_RCVD_TRUST, KHOP_THREADED, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-oa0-f48.google.com (HELO mail-oa0-f48.google.com) (209.85.219.48) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Feb 2013 16:37:21 +0000 Received: by mail-oa0-f48.google.com with SMTP id j1so1675065oag.7 for ; Wed, 06 Feb 2013 08:37:20 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.60.3.71 with SMTP id a7mr10536422oea.35.1360168633163; Wed, 06 Feb 2013 08:37:13 -0800 (PST) Received: by 10.76.133.193 with HTTP; Wed, 6 Feb 2013 08:37:12 -0800 (PST) In-Reply-To: <20130206141201.GA4484@bromo.med.uc.edu> References: <20130206141201.GA4484@bromo.med.uc.edu> Date: Wed, 6 Feb 2013 17:37:12 +0100 Message-ID: Subject: Re: [PATCH] Fix PR libitm/55693 From: Patrick Marlier To: Jack Howarth Cc: GCC Patches , iain@codesourcery.com, mikestump@comcast.net X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hi Jack, Thanks for having a look at this. However I don't understand why you need this: It seems you just add a macro TM_DESTRUCTOR which is the same as ENDFILE_SPEC. Maybe I missed something (I am updating my svn)... Also why HAVE_ELF_STYLE_WEAKREF is not defined for MacOS version where weak ref works? It could be better to define function to dummy only if HAVE_ELF_STYLE_WEAKREF is not set (and not testing the MacOS version). If we want to remove support for Xcode 4.2 (buggy linker), I think you should also have a look at the old commit to undo it (I remember a change in libitm which add a #ifdef MACH). Thanks. --- Patrick Index: gcc/config/i386/darwin.h =================================================================== --- gcc/config/i386/darwin.h (revision 195764) +++ gcc/config/i386/darwin.h (working copy) @@ -131,8 +131,7 @@ extern int darwin_emit_branch_islands; "%{Ofast|ffast-math|funsafe-math-optimizations:crtfastmath.o%s} \ %{mpc32:crtprec32.o%s} \ %{mpc64:crtprec64.o%s} \ - %{mpc80:crtprec80.o%s} \ - %{fgnu-tm: -lcrttme.o}" + %{mpc80:crtprec80.o%s}" TM_DESTRUCTOR #undef SUBTARGET_EXTRA_SPECS #define SUBTARGET_EXTRA_SPECS \ Index: gcc/config/darwin.h =================================================================== --- gcc/config/darwin.h (revision 195764) +++ gcc/config/darwin.h (working copy) @@ -363,7 +363,8 @@ extern GTY(()) int darwin_ms_struct; %{shared-libgcc:%:version-compare(< 10.5 mmacosx-version-min= crt3.o%s)}" /* We want a destructor last in the list. */ -#define ENDFILE_SPEC "%{fgnu-tm: -lcrttme.o}" +#define TM_DESTRUCTOR "%{fgnu-tm: -lcrttme.o}" +#define ENDFILE_SPEC TM_DESTRUCTOR #define DARWIN_EXTRA_SPECS \ { "darwin_crt1", DARWIN_CRT1_SPEC }, \