Patchwork [3/5] qt: define license

login
register
mail settings
Submitter Luca Ceresoli
Date Feb. 6, 2013, 4:24 p.m.
Message ID <1360167853-7177-3-git-send-email-luca@lucaceresoli.net>
Download mbox | patch
Permalink /patch/218686/
State Superseded
Headers show

Comments

Luca Ceresoli - Feb. 6, 2013, 4:24 p.m.
Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
 package/qt/qt.mk |    2 ++
 1 file changed, 2 insertions(+)
Thomas Petazzoni - Feb. 6, 2013, 4:58 p.m.
Dear Luca Ceresoli,

On Wed,  6 Feb 2013 17:24:11 +0100, Luca Ceresoli wrote:

> +QT_LICENSE = LGPLv2.1 with exceptions or GPLv3 or commercial
> +QT_LICENSE_FILES = LICENSE.LGPL LGPL_EXCEPTION.txt LICENSE.GPL3

If Qt5, I've done:

+ifeq ($(BR2_PACKAGE_QT5BASE_LICENSE_APPROVED),y)
+QT5BASE_CONFIGURE_OPTS += -opensource -confirm-license
+QT5BASE_LICENSE = LGPLv2.1 or GPLv3.0
+QT5BASE_LICENSE_FILES = LICENSE.GPL LICENSE.LGPL LGPL_EXCEPTION.txt
+else
+QT5BASE_LICENSE = Commercial license
+QT5BASE_REDISTRIBUTE = NO
+endif

See
http://git.free-electrons.com/users/thomas-petazzoni/buildroot/commit/?h=qt5&id=7c1f7b9967d814e3f5c838e7090ac04b9d06af51

Best regards,

Thomas
Arnout Vandecappelle - Feb. 6, 2013, 8:04 p.m.
On 06/02/13 17:58, Thomas Petazzoni wrote:
> Dear Luca Ceresoli,
>
> On Wed,  6 Feb 2013 17:24:11 +0100, Luca Ceresoli wrote:
>
>> +QT_LICENSE = LGPLv2.1 with exceptions or GPLv3 or commercial
>> +QT_LICENSE_FILES = LICENSE.LGPL LGPL_EXCEPTION.txt LICENSE.GPL3
>
> If Qt5, I've done:
>
> +ifeq ($(BR2_PACKAGE_QT5BASE_LICENSE_APPROVED),y)
> +QT5BASE_CONFIGURE_OPTS += -opensource -confirm-license
> +QT5BASE_LICENSE = LGPLv2.1 or GPLv3.0

  Isn't it GPLv3 rather than GPLv3.0?

> +QT5BASE_LICENSE_FILES = LICENSE.GPL LICENSE.LGPL LGPL_EXCEPTION.txt
> +else
> +QT5BASE_LICENSE = Commercial license
> +QT5BASE_REDISTRIBUTE = NO

  Hm. If LICENSE_APPROVED is not set, it means that the compilation will 
stop to ask the user which license s/he wants. That doesn't necessarily 
imply the commercial license. So I prefer an OR construct here as well.
And anyway, even if you hold a commercial license you're still free to 
distribute it under one of the other licenses.

  By the way, I'd also call it "Digia Qt Commercial license" to make it 
more explicit. But that's just an opinion.


  Regards,
  Arnout

> +endif
>
> See
> http://git.free-electrons.com/users/thomas-petazzoni/buildroot/commit/?h=qt5&id=7c1f7b9967d814e3f5c838e7090ac04b9d06af51
>
> Best regards,
>
> Thomas
>
Luca Ceresoli - Feb. 7, 2013, 8:34 a.m.
Arnout Vandecappelle wrote:
> On 06/02/13 17:58, Thomas Petazzoni wrote:
>> Dear Luca Ceresoli,
>>
>> On Wed,  6 Feb 2013 17:24:11 +0100, Luca Ceresoli wrote:
>>
>>> +QT_LICENSE = LGPLv2.1 with exceptions or GPLv3 or commercial
>>> +QT_LICENSE_FILES = LICENSE.LGPL LGPL_EXCEPTION.txt LICENSE.GPL3
>>
>> If Qt5, I've done:
>>
>> +ifeq ($(BR2_PACKAGE_QT5BASE_LICENSE_APPROVED),y)
>> +QT5BASE_CONFIGURE_OPTS += -opensource -confirm-license
>> +QT5BASE_LICENSE = LGPLv2.1 or GPLv3.0
>
>   Isn't it GPLv3 rather than GPLv3.0?
>
>> +QT5BASE_LICENSE_FILES = LICENSE.GPL LICENSE.LGPL LGPL_EXCEPTION.txt
>> +else
>> +QT5BASE_LICENSE = Commercial license
>> +QT5BASE_REDISTRIBUTE = NO
>
>   Hm. If LICENSE_APPROVED is not set, it means that the compilation will
> stop to ask the user which license s/he wants. That doesn't necessarily
> imply the commercial license. So I prefer an OR construct here as well.
> And anyway, even if you hold a commercial license you're still free to
> distribute it under one of the other licenses.

How about the following?

QT_LICENSE = LGPLv2.1 with exceptions or GPLv3
ifneq ($(BR2_PACKAGE_QT5BASE_LICENSE_APPROVED),y)
QT_LICENSE += or Digia Qt Commercial license
endif
QT_LICENSE_FILES = LICENSE.LGPL LGPL_EXCEPTION.txt LICENSE.GPL3

This way we still cannot automatically (and safely) set
_REDISTRIBUTE = NO, unless we add an explicit "Use commercial license"
knob in menuconfig.

Luca


>
>   By the way, I'd also call it "Digia Qt Commercial license" to make it
> more explicit. But that's just an opinion.
Arnout Vandecappelle - Feb. 7, 2013, 5:01 p.m.
On 07/02/13 09:34, Luca Ceresoli wrote:
> Arnout Vandecappelle wrote:
>> On 06/02/13 17:58, Thomas Petazzoni wrote:
>>> Dear Luca Ceresoli,
>>>
>>> On Wed,  6 Feb 2013 17:24:11 +0100, Luca Ceresoli wrote:
>>>
>>>> +QT_LICENSE = LGPLv2.1 with exceptions or GPLv3 or commercial
>>>> +QT_LICENSE_FILES = LICENSE.LGPL LGPL_EXCEPTION.txt LICENSE.GPL3
>>>
>>> If Qt5, I've done:
>>>
>>> +ifeq ($(BR2_PACKAGE_QT5BASE_LICENSE_APPROVED),y)
>>> +QT5BASE_CONFIGURE_OPTS += -opensource -confirm-license
>>> +QT5BASE_LICENSE = LGPLv2.1 or GPLv3.0
>>
>>   Isn't it GPLv3 rather than GPLv3.0?
>>
>>> +QT5BASE_LICENSE_FILES = LICENSE.GPL LICENSE.LGPL LGPL_EXCEPTION.txt
>>> +else
>>> +QT5BASE_LICENSE = Commercial license
>>> +QT5BASE_REDISTRIBUTE = NO
>>
>>   Hm. If LICENSE_APPROVED is not set, it means that the compilation will
>> stop to ask the user which license s/he wants. That doesn't necessarily
>> imply the commercial license. So I prefer an OR construct here as well.
>> And anyway, even if you hold a commercial license you're still free to
>> distribute it under one of the other licenses.
>
> How about the following?
>
> QT_LICENSE = LGPLv2.1 with exceptions or GPLv3
> ifneq ($(BR2_PACKAGE_QT5BASE_LICENSE_APPROVED),y)
> QT_LICENSE += or Digia Qt Commercial license
> endif
> QT_LICENSE_FILES = LICENSE.LGPL LGPL_EXCEPTION.txt LICENSE.GPL3

  Sounds good to me.


> This way we still cannot automatically (and safely) set
> _REDISTRIBUTE = NO, unless we add an explicit "Use commercial license"
> knob in menuconfig.

  I don't think that's very important.

  Regards,
  Arnout
Luca Ceresoli - Feb. 7, 2013, 10:40 p.m.
Arnout Vandecappelle wrote:
>> How about the following?
>>
>> QT_LICENSE = LGPLv2.1 with exceptions or GPLv3
>> ifneq ($(BR2_PACKAGE_QT5BASE_LICENSE_APPROVED),y)
>> QT_LICENSE += or Digia Qt Commercial license
>> endif
>> QT_LICENSE_FILES = LICENSE.LGPL LGPL_EXCEPTION.txt LICENSE.GPL3
>
>   Sounds good to me.
>
>
>> This way we still cannot automatically (and safely) set
>> _REDISTRIBUTE = NO, unless we add an explicit "Use commercial license"
>> knob in menuconfig.
>
>   I don't think that's very important.

I agree. In fact I did not care about this in the v2 patch I just sent.

Luca

Patch

diff --git a/package/qt/qt.mk b/package/qt/qt.mk
index ee1a88b..06237ef 100644
--- a/package/qt/qt.mk
+++ b/package/qt/qt.mk
@@ -16,6 +16,8 @@  QT_SOURCE  = qt-everywhere-opensource-src-$(QT_VERSION).tar.gz
 QT_SITE    = http://releases.qt-project.org/qt4/source
 QT_DEPENDENCIES = host-pkgconf
 QT_INSTALL_STAGING = YES
+QT_LICENSE = LGPLv2.1 with exceptions or GPLv3 or commercial
+QT_LICENSE_FILES = LICENSE.LGPL LGPL_EXCEPTION.txt LICENSE.GPL3
 
 ifeq ($(BR2_PACKAGE_QT_LICENSE_APPROVED),y)
 QT_CONFIGURE_OPTS += -opensource -confirm-license