Patchwork [70/93] samsung-laptop: Disable on EFI hardware

mail settings
Submitter Herton Ronaldo Krzesinski
Date Feb. 5, 2013, 10:06 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/218578/
State New
Headers show


Herton Ronaldo Krzesinski - Feb. 5, 2013, 10:06 p.m. -stable review patch.  If anyone has any objections, please let me know.


From: Matt Fleming <>

commit e0094244e41c4d0c7ad69920681972fc45d8ce34 upstream.

It has been reported that running this driver on some Samsung laptops
with EFI can cause those machines to become bricked as detailed in the
following report,

There have also been reports of this driver causing Machine Check
Exceptions on recent EFI-enabled Samsung laptops,

So disable it if booting from EFI since this driver relies on
grovelling around in the BIOS memory map which isn't going to work.

Cc: Corentin Chary <>
Cc: Matthew Garrett <>
Cc: Colin Ian King <>
Cc: Steve Langasek <>
Signed-off-by: Matt Fleming <>
Signed-off-by: H. Peter Anvin <>
[ herton: adjust context ]
Signed-off-by: Herton Ronaldo Krzesinski <>
 drivers/platform/x86/samsung-laptop.c |    4 ++++
 1 file changed, 4 insertions(+)


diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c
index 1afbe5e..de9f432 100644
--- a/drivers/platform/x86/samsung-laptop.c
+++ b/drivers/platform/x86/samsung-laptop.c
@@ -26,6 +26,7 @@ 
 #include <linux/seq_file.h>
 #include <linux/debugfs.h>
 #include <linux/ctype.h>
+#include <linux/efi.h>
 #include <acpi/video.h>
@@ -1527,6 +1528,9 @@  static int __init samsung_init(void)
 	struct samsung_laptop *samsung;
 	int ret;
+	if (efi_enabled(EFI_BOOT))
+		return -ENODEV;
 	quirks = &samsung_unknown;
 	if (!force && !dmi_check_system(samsung_dmi_table))
 		return -ENODEV;