From patchwork Wed Feb 6 11:22:45 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: rtc: core: Prevent repeated calling of alarm_irq_enable(). Date: Wed, 06 Feb 2013 01:22:45 -0000 From: Jonghwa Lee X-Patchwork-Id: 218557 Message-Id: <1360149765-19565-1-git-send-email-jonghwa3.lee@samsung.com> To: linux-kernel@vger.kernel.org Cc: a.zummo@towertech.it, Andrew Morton , rtc-linux@googlegroups.com, Jonghwa Lee This patch removes repeated execution of disabling alarm in rtc_alarm_irq_enable() of rtc core interface. It made useless call even all alarm had been disabled from rtc_timer_remove(). We'd better to skip disabling alarm when timer queue is empty. Signed-off-by: Jonghwa Lee --- drivers/rtc/interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/interface.c b/drivers/rtc/interface.c index 9592b93..11cfb76 100644 --- a/drivers/rtc/interface.c +++ b/drivers/rtc/interface.c @@ -428,7 +428,7 @@ int rtc_alarm_irq_enable(struct rtc_device *rtc, unsigned int enabled) rtc_timer_remove(rtc, &rtc->aie_timer); } - if (err) + if (err || !rtc->timerqueue.next) /* nothing */; else if (!rtc->ops) err = -ENODEV;