From patchwork Wed Feb 6 06:14:26 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wang Shilong X-Patchwork-Id: 218489 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id E88A72C029E for ; Wed, 6 Feb 2013 17:14:46 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751088Ab3BFGOq (ORCPT ); Wed, 6 Feb 2013 01:14:46 -0500 Received: from mail-da0-f50.google.com ([209.85.210.50]:42804 "EHLO mail-da0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750716Ab3BFGOp (ORCPT ); Wed, 6 Feb 2013 01:14:45 -0500 Received: by mail-da0-f50.google.com with SMTP id h15so467370dan.23 for ; Tue, 05 Feb 2013 22:14:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer; bh=y6If7001IK6pLhCASZcTXADMPXWs9QLCHG0A4gvEfuk=; b=V19s3fbMDj/6NFLbIlNNOL2pa/EcuRmMrjDTnIJVs0RWw799y1hgd3WT3ZGjuQWFuc OISFEGM+ylEC+opvT4lkPqWbxfCmh4xxrbUb3T0RvJC8T/TaBNapdQtLJnxE1lS8t/BK I9/oZEF//ShtHmVJZ97TU9vxNj5/YKjndQNhigGFTQhMzqR+teAYOGxNxw2iebj/ZL5y Q0b7eFL8k05lPVElhw7v3Gaj6gnCVqSRqZ1xoZzDe0F2ljtJa3vCPsasn7ePSxQ3jU0T aaQMNzYlMzL1tFGa9JN3QtZDy1+JiPH9apdnnkRPXBquN58CqiBJ0nTHDXhP45Xnz5Et PlVQ== X-Received: by 10.66.73.165 with SMTP id m5mr72275377pav.78.1360131285050; Tue, 05 Feb 2013 22:14:45 -0800 (PST) Received: from localhost.localdomain ([112.4.51.43]) by mx.google.com with ESMTPS id bi2sm35128044pab.18.2013.02.05.22.14.42 (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 05 Feb 2013 22:14:44 -0800 (PST) From: Wang shilong To: jack@suse.cz Cc: linux-ext4@vger.kernel.org, Wang shilong , Wang Shilong Subject: [PATCH 1/3] Ext2: remove the overhead check about sb in the function ext2_new_blocks Date: Wed, 6 Feb 2013 14:14:26 +0800 Message-Id: <1360131268-1615-1-git-send-email-wangshilong1991@gmail.com> X-Mailer: git-send-email 1.7.11.7 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: Wang Shilong It can be guranteed that inode->i_sb should not be null in vfs. So here the check about it is overhead. Signed-off-by: Wang Shilong --- fs/ext2/balloc.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c index 1c36139..22993a0 100644 --- a/fs/ext2/balloc.c +++ b/fs/ext2/balloc.c @@ -1239,10 +1239,6 @@ ext2_fsblk_t ext2_new_blocks(struct inode *inode, ext2_fsblk_t goal, *errp = -ENOSPC; sb = inode->i_sb; - if (!sb) { - printk("ext2_new_blocks: nonexistent device"); - return 0; - } /* * Check quota for allocation of this block.