Patchwork [3/3] Ext2: remove the static function release_blocks to optimize the kernel

login
register
mail settings
Submitter Wang shilong
Date Feb. 6, 2013, 8:03 p.m.
Message ID <5112B70B.7020805@gmail.com>
Download mbox | patch
Permalink /patch/218485/
State Not Applicable
Headers show

Comments

Wang shilong - Feb. 6, 2013, 8:03 p.m.
From: Wang Shilong <wangsl-fnst@cn.fujitsu.com>

Because the static function 'release_blocks' is only called
when releasing blocks,it will be more simple and efficient to
call the function 'percpu_counter_add' directly.

Signed-off-by: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
---
fs/ext2/balloc.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)

Patch

diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c
index 9d372bf..d5a6afd 100644
--- a/fs/ext2/balloc.c
+++ b/fs/ext2/balloc.c
@@ -159,15 +159,6 @@  read_block_bitmap(struct super_block *sb, unsigned int block_group)
return bh;
}

-static void release_blocks(struct super_block *sb, int count)
-{
- if (count) {
- struct ext2_sb_info *sbi = EXT2_SB(sb);
-
- percpu_counter_add(&sbi->s_freeblocks_counter, count);
- }
-}
-
static void group_adjust_blocks(struct super_block *sb, int group_no,
struct ext2_group_desc *desc, struct buffer_head *bh, int count)
{
@@ -569,7 +560,7 @@  do_more:
error_return:
brelse(bitmap_bh);
if (freed) {
- release_blocks(sb, freed);
+ percpu_counter_add(&sbi->s_freeblocks_counter, freed);
dquot_free_block_nodirty(inode, freed);
mark_inode_dirty(inode);
}