Patchwork [1/3] Ext2: remove the overhead check about sb in the function ext2_new_blocks

login
register
mail settings
Submitter Wang shilong
Date Feb. 6, 2013, 8:01 p.m.
Message ID <5112B68D.3080108@gmail.com>
Download mbox | patch
Permalink /patch/218483/
State Not Applicable
Headers show

Comments

Wang shilong - Feb. 6, 2013, 8:01 p.m.
From: Wang Shilong <wangsl-fnst@cn.fujitsu.com>

It can be guranteed that inode->i_sb should not be null in vfs.
So here the check about it is overhead.

Signed-off-by: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
---
fs/ext2/balloc.c | 4 ----
1 file changed, 4 deletions(-)

Patch

diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c
index 1c36139..22993a0 100644
--- a/fs/ext2/balloc.c
+++ b/fs/ext2/balloc.c
@@ -1239,10 +1239,6 @@  ext2_fsblk_t ext2_new_blocks(struct inode *inode, ext2_fsblk_t goal,

*errp = -ENOSPC;
sb = inode->i_sb;
- if (!sb) {
- printk("ext2_new_blocks: nonexistent device");
- return 0;
- }

/*
* Check quota for allocation of this block.