From patchwork Wed Feb 6 00:00:23 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 218465 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 1B1152C02C5 for ; Wed, 6 Feb 2013 11:00:57 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754032Ab3BFAAx (ORCPT ); Tue, 5 Feb 2013 19:00:53 -0500 Received: from mail-oa0-f42.google.com ([209.85.219.42]:43244 "EHLO mail-oa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751053Ab3BFAAw (ORCPT ); Tue, 5 Feb 2013 19:00:52 -0500 Received: by mail-oa0-f42.google.com with SMTP id i18so903870oag.15 for ; Tue, 05 Feb 2013 16:00:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:cc:subject:date:message-id:x-mailer; bh=81zpm3BfxvluSqB92pIXIxGXxLTSXL/6VSejYD7YE5I=; b=HHpAGAR15wqaLp5mIXop/XufcVduRIqAJ7zTV4xZXYVq/s8EuAD8btAeT5e0+3D30p gU9LL8PME0xXNJnnNWZtmBlO+9BnCIil/1MIuY2A9uNxshyA6RL5YMMDrILr19L1V/69 X6GMUI0ROw+y7TwOyeTiX9zjfs1610ZrZUSqxg+lVpusZ1HkBQbbvhhUdvuCJ6OUHLxf uN3u1T0xJwcWvthY0VVb6h6spVFgmb8oQfN6wUVBehg3Ak1cgsxEBPriCD+mko44/owt LJsAr3Ccus5klcl9IYBdvq9rU7I6XKPp9STO2JT+1Qz2PCQenxFNzRy5nIyoNSacZaZb wItg== X-Received: by 10.182.227.33 with SMTP id rx1mr19462749obc.69.1360108851844; Tue, 05 Feb 2013 16:00:51 -0800 (PST) Received: from linux-2liw.lan (CPE-75-81-36-228.kc.res.rr.com. [75.81.36.228]) by mx.google.com with ESMTPS id z5sm27746956oeh.1.2013.02.05.16.00.48 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 05 Feb 2013 16:00:51 -0800 (PST) From: Larry Finger To: linville@tuxdriver.com Cc: linux-wireless@vger.kernel.org, Larry Finger , netdev@vger.kernel.org, Stable Subject: [PATCH] rtlwifi: rtl8192cu: Fix NULL dereference BUG when using new_id Date: Tue, 5 Feb 2013 18:00:23 -0600 Message-Id: <1360108823-5141-1-git-send-email-Larry.Finger@lwfinger.net> X-Mailer: git-send-email 1.8.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When the new_id entry is used for a foreign USB device, rtlwifi BUGS with a NULL pointer dereference. Signed-off-by: Larry Finger Cc: Stable --- John, Although this patch should be backported to stable kernels, the new_id feature is rarely used, thus the patch should not have any particular priority. Larry --- drivers/net/wireless/rtlwifi/usb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/rtlwifi/usb.c b/drivers/net/wireless/rtlwifi/usb.c index d42bbe2..77a7517 100644 --- a/drivers/net/wireless/rtlwifi/usb.c +++ b/drivers/net/wireless/rtlwifi/usb.c @@ -977,6 +977,9 @@ int rtl_usb_probe(struct usb_interface *intf, rtl_dbgp_flag_init(hw); /* Init IO handler */ _rtl_usb_io_handler_init(&udev->dev, hw); + if (!rtlpriv->cfg || !rtlpriv->cfg->ops || + !rtlpriv->cfg->ops->read_chip_version) + return -ENODEV; rtlpriv->cfg->ops->read_chip_version(hw); /*like read eeprom and so on */ rtlpriv->cfg->ops->read_eeprom_info(hw);