From patchwork Tue Feb 5 22:06:54 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [65/93] xfs: Fix possible use-after-free with AIO Date: Tue, 05 Feb 2013 12:06:54 -0000 From: Herton Ronaldo Krzesinski X-Patchwork-Id: 218427 Message-Id: <1360102042-10732-66-git-send-email-herton.krzesinski@canonical.com> To: linux-kernel@vger.kernel.org, stable@vger.kernel.org, kernel-team@lists.ubuntu.com Cc: Ben Myers , Jan Kara , xfs@oss.sgi.com 3.5.7.5 -stable review patch. If anyone has any objections, please let me know. ------------------ From: Jan Kara commit 4b05d09c18d9aa62d2e7fb4b057f54e5a38963f5 upstream. Running AIO is pinning inode in memory using file reference. Once AIO is completed using aio_complete(), file reference is put and inode can be freed from memory. So we have to be sure that calling aio_complete() is the last thing we do with the inode. CC: xfs@oss.sgi.com CC: Ben Myers Signed-off-by: Jan Kara Reviewed-by: Ben Myers Signed-off-by: Ben Myers Signed-off-by: Herton Ronaldo Krzesinski --- fs/xfs/xfs_aops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c index 8dad722..6868548 100644 --- a/fs/xfs/xfs_aops.c +++ b/fs/xfs/xfs_aops.c @@ -86,11 +86,11 @@ xfs_destroy_ioend( } if (ioend->io_iocb) { + inode_dio_done(ioend->io_inode); if (ioend->io_isasync) { aio_complete(ioend->io_iocb, ioend->io_error ? ioend->io_error : ioend->io_result, 0); } - inode_dio_done(ioend->io_inode); } mempool_free(ioend, xfs_ioend_pool);