| Message ID | 1360081335-6594-9-git-send-email-armbru@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 02/05/2013 09:22 AM, Markus Armbruster wrote: > This is a new device, so there's no compatibility to maintain, and its > use case isn't common enough to justify shorthand syntax. > > Signed-off-by: Markus Armbruster <armbru@redhat.com> > --- > qemu-char.c | 5 ----- > 1 file changed, 5 deletions(-) Reviewed-by: Eric Blake <eblake@redhat.com> We can always add shorthand later, if it turns out to be popular; but we can't take shorthand away once it is added, so I agree with being conservative on the first release by having no shorthand.
diff --git a/qemu-char.c b/qemu-char.c index 9460a9d..ab011c6 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2883,11 +2883,6 @@ QemuOpts *qemu_chr_parse_compat(const char *label, const char *filename) qemu_opt_set(opts, "path", filename); return opts; } - if (strstart(filename, "memory", &p)) { - qemu_opt_set(opts, "backend", "memory"); - qemu_opt_set(opts, "maxcapacity", p); - return opts; - } if (strstart(filename, "file:", &p)) { qemu_opt_set(opts, "backend", "file"); qemu_opt_set(opts, "path", p);
This is a new device, so there's no compatibility to maintain, and its use case isn't common enough to justify shorthand syntax. Signed-off-by: Markus Armbruster <armbru@redhat.com> --- qemu-char.c | 5 ----- 1 file changed, 5 deletions(-)