Patchwork [v2.6.29,1/2] gianfar: Fix BD_LENGTH_MASK definition

login
register
mail settings
Submitter Andy Fleming
Date Feb. 4, 2009, 1:16 a.m.
Message ID <1233710223-17808-1-git-send-email-afleming@freescale.com>
Download mbox | patch
Permalink /patch/21825/
State Accepted
Delegated to: David Miller
Headers show

Comments

Andy Fleming - Feb. 4, 2009, 1:16 a.m.
BD_LENGTH_MASK is supposed to catch the low 16-bits of the status field, not
the low byte.  The old way, we would never be able to clean up tx packets with
sizes divisible by 256.

Signed-off-by: Andy Fleming <afleming@freescale.com>
---
 drivers/net/gianfar.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
David Miller - Feb. 5, 2009, 12:38 a.m.
From: Andy Fleming <afleming@freescale.com>
Date: Tue,  3 Feb 2009 19:16:59 -0600

> BD_LENGTH_MASK is supposed to catch the low 16-bits of the status field, not
> the low byte.  The old way, we would never be able to clean up tx packets with
> sizes divisible by 256.
> 
> Signed-off-by: Andy Fleming <afleming@freescale.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/gianfar.h b/drivers/net/gianfar.h
index b1a8334..eaa8689 100644
--- a/drivers/net/gianfar.h
+++ b/drivers/net/gianfar.h
@@ -312,7 +312,7 @@  extern const char gfar_driver_version[];
 #define ATTRELI_EI(x) (x)
 
 #define BD_LFLAG(flags) ((flags) << 16)
-#define BD_LENGTH_MASK		0x00ff
+#define BD_LENGTH_MASK		0x0000ffff
 
 /* TxBD status field bits */
 #define TXBD_READY		0x8000