Patchwork ib: fwts_ioport: fix calling unmatched I/O function in a help function.

login
register
mail settings
Submitter Alex Hung
Date Feb. 5, 2013, 4:30 a.m.
Message ID <1360038659-3426-1-git-send-email-alex.hung@canonical.com>
Download mbox | patch
Permalink /patch/218155/
State Accepted
Headers show

Comments

Alex Hung - Feb. 5, 2013, 4:30 a.m.
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 src/lib/src/fwts_ioport.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Colin King - Feb. 13, 2013, 9:12 a.m.
On 05/02/13 04:30, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>   src/lib/src/fwts_ioport.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lib/src/fwts_ioport.c b/src/lib/src/fwts_ioport.c
> index 5aedc5e..4da6a7a 100644
> --- a/src/lib/src/fwts_ioport.c
> +++ b/src/lib/src/fwts_ioport.c
> @@ -129,7 +129,7 @@ int fwts_outl(uint32_t port, uint32_t value)
>   		return FWTS_ERROR;
>
>   	signal(SIGSEGV, segv_handler);
> -	outw(port, value);
> +	outl(port, value);
>   	signal(SIGSEGV, SIG_DFL);
>
>   	return FWTS_OK;
>

Thanks for spotting this. Once again cut-n-paste coding error bites me.

Colin
Colin King - Feb. 13, 2013, 9:37 a.m.
On 05/02/13 04:30, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>   src/lib/src/fwts_ioport.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lib/src/fwts_ioport.c b/src/lib/src/fwts_ioport.c
> index 5aedc5e..4da6a7a 100644
> --- a/src/lib/src/fwts_ioport.c
> +++ b/src/lib/src/fwts_ioport.c
> @@ -129,7 +129,7 @@ int fwts_outl(uint32_t port, uint32_t value)
>   		return FWTS_ERROR;
>
>   	signal(SIGSEGV, segv_handler);
> -	outw(port, value);
> +	outl(port, value);
>   	signal(SIGSEGV, SIG_DFL);
>
>   	return FWTS_OK;
>
Keng-Yu, can you wiggle the patch before applying it so the title is:

lib: fwts_ioport: fix calling unmatched I/O function in a help function.

Colin
Keng-Yu Lin - Feb. 18, 2013, 2:04 p.m.
On Wed, Feb 13, 2013 at 5:37 PM, Colin Ian King
<colin.king@canonical.com> wrote:
> On 05/02/13 04:30, Alex Hung wrote:
>>
>> Signed-off-by: Alex Hung <alex.hung@canonical.com>
>> ---
>>   src/lib/src/fwts_ioport.c |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/lib/src/fwts_ioport.c b/src/lib/src/fwts_ioport.c
>> index 5aedc5e..4da6a7a 100644
>> --- a/src/lib/src/fwts_ioport.c
>> +++ b/src/lib/src/fwts_ioport.c
>> @@ -129,7 +129,7 @@ int fwts_outl(uint32_t port, uint32_t value)
>>                 return FWTS_ERROR;
>>
>>         signal(SIGSEGV, segv_handler);
>> -       outw(port, value);
>> +       outl(port, value);
>>         signal(SIGSEGV, SIG_DFL);
>>
>>         return FWTS_OK;
>>
> Keng-Yu, can you wiggle the patch before applying it so the title is:
>
> lib: fwts_ioport: fix calling unmatched I/O function in a help function.
>
> Colin
>
>
Colin, sure, no problem.

Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Ivan Hu - Feb. 19, 2013, 7:04 a.m.
On 02/05/2013 12:30 PM, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>   src/lib/src/fwts_ioport.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lib/src/fwts_ioport.c b/src/lib/src/fwts_ioport.c
> index 5aedc5e..4da6a7a 100644
> --- a/src/lib/src/fwts_ioport.c
> +++ b/src/lib/src/fwts_ioport.c
> @@ -129,7 +129,7 @@ int fwts_outl(uint32_t port, uint32_t value)
>   		return FWTS_ERROR;
>
>   	signal(SIGSEGV, segv_handler);
> -	outw(port, value);
> +	outl(port, value);
>   	signal(SIGSEGV, SIG_DFL);
>
>   	return FWTS_OK;
>
Acked-by: Ivan Hu <ivan.hu@canonical.com>

Patch

diff --git a/src/lib/src/fwts_ioport.c b/src/lib/src/fwts_ioport.c
index 5aedc5e..4da6a7a 100644
--- a/src/lib/src/fwts_ioport.c
+++ b/src/lib/src/fwts_ioport.c
@@ -129,7 +129,7 @@  int fwts_outl(uint32_t port, uint32_t value)
 		return FWTS_ERROR;
 
 	signal(SIGSEGV, segv_handler);
-	outw(port, value);
+	outl(port, value);
 	signal(SIGSEGV, SIG_DFL);
 
 	return FWTS_OK;