From patchwork Tue Feb 5 01:57:30 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: ulog: add protection when remove ipt_ULOG From: Gao feng X-Patchwork-Id: 218131 Message-Id: <1360029450-6673-1-git-send-email-gaofeng@cn.fujitsu.com> To: netfilter-devel@vger.kernel.org Cc: Gao feng Date: Tue, 5 Feb 2013 09:57:30 +0800 We should add a lock protection when we free the skb, because it maybe used by ipt_ulog_packet right now. Signed-off-by: Gao feng --- net/ipv4/netfilter/ipt_ULOG.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv4/netfilter/ipt_ULOG.c b/net/ipv4/netfilter/ipt_ULOG.c index b5ef3cb..b390002 100644 --- a/net/ipv4/netfilter/ipt_ULOG.c +++ b/net/ipv4/netfilter/ipt_ULOG.c @@ -430,11 +430,12 @@ static void __exit ulog_tg_exit(void) pr_debug("timer was pending, deleting\n"); del_timer(&ub->timer); } - + spin_lock_bh(&ulog_lock); if (ub->skb) { kfree_skb(ub->skb); ub->skb = NULL; } + spin_unlock_bh(&ulog_lock); } }