From patchwork Tue Feb 5 00:05:17 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cong Ding X-Patchwork-Id: 218124 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 20CFE2C02F8 for ; Tue, 5 Feb 2013 11:05:17 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754458Ab3BEAFP (ORCPT ); Mon, 4 Feb 2013 19:05:15 -0500 Received: from mail-bk0-f51.google.com ([209.85.214.51]:51422 "EHLO mail-bk0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754748Ab3BEAFO (ORCPT ); Mon, 4 Feb 2013 19:05:14 -0500 Received: by mail-bk0-f51.google.com with SMTP id ik5so2997053bkc.24 for ; Mon, 04 Feb 2013 16:05:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=N2NC5p4i9yYX5x3McDFC924RcE65+pDV6lVpVdsEIfQ=; b=0hdOvFX3MP2HucDVtc7qGK3PfCoIvy538x/XU0jnv0kPAxISCuDP7GBilRrIK8cD8+ 8TTi7b/f0Mir13/NGd4q+JKEux0WMPzEUxqGNxjTDfY2BlPV7h6mPmax7n6+E/T91IkJ tgl4zTHim06nGYIsKWdl9SpSl4jZGc9lwda8MqN2sL7ehMll8qL6qghYSXKG4S69mCcd XIrFazC0KtU6McAfY8a9EBQNoiNppquMvwF2xFfBe2CaWzdlQhv3xMlJld/NLA8ajvec RAeTSvsLINaCRo5byv/3a56UPRpnOoBFJpb20hWZTp4/dVwzHUPFbGZmW1PHgtgOMpbF 9iPA== X-Received: by 10.204.147.81 with SMTP id k17mr6088762bkv.70.1360022712930; Mon, 04 Feb 2013 16:05:12 -0800 (PST) Received: from gmail.com (s5-net.informatik.uni-goettingen.de. [134.76.81.35]) by mx.google.com with ESMTPS id fs20sm5868318bkc.8.2013.02.04.16.05.11 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 04 Feb 2013 16:05:11 -0800 (PST) Date: Tue, 5 Feb 2013 01:05:17 +0100 From: Cong Ding To: Kyungmin Park Cc: Wolfram Sang , Andrew Morton , Karol Lewandowski , Haojian Zhuang , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] i2c: busses/i2c-pxa.c: fix potential null pointer dereference error Message-ID: <20130205000517.GB9969@gmail.com> References: <1360015899-13706-1-git-send-email-dinggnu@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org If it goes to eclk through line 1107, the variable res would be NULL. It will cause a null pointer dereference error if we call release_mem_region. Signed-off-by: Cong Ding --- drivers/i2c/busses/i2c-pxa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c index 1034d93..00df535 100644 --- a/drivers/i2c/busses/i2c-pxa.c +++ b/drivers/i2c/busses/i2c-pxa.c @@ -1211,7 +1211,8 @@ eremap: eclk: kfree(i2c); emalloc: - release_mem_region(res->start, resource_size(res)); + if (res) + release_mem_region(res->start, resource_size(res)); return ret; }