From patchwork Mon Feb 4 22:11:36 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cong Ding X-Patchwork-Id: 218098 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 2C27C2C02AD for ; Tue, 5 Feb 2013 09:11:48 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754780Ab3BDWLq (ORCPT ); Mon, 4 Feb 2013 17:11:46 -0500 Received: from mail-bk0-f43.google.com ([209.85.214.43]:58204 "EHLO mail-bk0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754652Ab3BDWLq (ORCPT ); Mon, 4 Feb 2013 17:11:46 -0500 Received: by mail-bk0-f43.google.com with SMTP id jm19so3035639bkc.30 for ; Mon, 04 Feb 2013 14:11:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer; bh=lqyMURpy8X4pTwcC5qTyUcUE9d/ns3gMc4Atk9YmDRs=; b=Jw0a+RzJAo0uhR3E3cK2iIjIAOdgUwVQpEP+285zRyaYNW0jr6Ra7hLgSgBMMzfepX 6iqw97dV71Yxc1DUjq7oUCPv4BRarYEv64DEYAVAqniJV9g2qJ98M6FQnWQSSYX/osgE QGuDpeNGkKnXut+b4xvge5lfkBjg7GWHDHlrDbDCophG7DDEpNaaSRLiejc00D6XLWy5 7yU6gqg0AAcE4kxBjnmCZPbyjRQs0jndyyZGbP4D57mE74J3+hoxjTKeC6fVZTASRydU w7JGp0w5y1C6WAObfT2Mp3BmWSHju0VwgSlkPx6hNDFTYM4IFF3uZkxPrs8UBYJ9waa0 4bdA== X-Received: by 10.204.8.16 with SMTP id f16mr6149802bkf.81.1360015904542; Mon, 04 Feb 2013 14:11:44 -0800 (PST) Received: from NET.net.loc (s5-net.informatik.uni-goettingen.de. [134.76.81.35]) by mx.google.com with ESMTPS id go8sm5833235bkc.20.2013.02.04.14.11.42 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 04 Feb 2013 14:11:43 -0800 (PST) From: Cong Ding To: Wolfram Sang , Andrew Morton , Karol Lewandowski , Kyungmin Park , Haojian Zhuang , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Cong Ding Subject: [PATCH] i2c: busses/i2c-pxa.c: fix potential null pointer dereference error Date: Mon, 4 Feb 2013 23:11:36 +0100 Message-Id: <1360015899-13706-1-git-send-email-dinggnu@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org If it goes to eclk through line 1107, the variable res would be NULL. It will cause a null pointer dereference error if we call release_mem_region. Signed-off-by: Cong Ding --- drivers/i2c/busses/i2c-pxa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c index 1034d93..eadf1a4 100644 --- a/drivers/i2c/busses/i2c-pxa.c +++ b/drivers/i2c/busses/i2c-pxa.c @@ -1211,7 +1211,8 @@ eremap: eclk: kfree(i2c); emalloc: - release_mem_region(res->start, resource_size(res)); + if (!res) + release_mem_region(res->start, resource_size(res)); return ret; }