Patchwork [3.5.y.z,extended,stable] Patch "[libata] ahci: Fix lack of command retry after a success" has been added to staging queue

mail settings
Submitter Herton Ronaldo Krzesinski
Date Feb. 4, 2013, 9:46 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/218080/
State New
Headers show


Herton Ronaldo Krzesinski - Feb. 4, 2013, 9:46 p.m.
This is a note to let you know that I have just added a patch titled

    [libata] ahci: Fix lack of command retry after a success

to the linux-3.5.y-queue branch of the 3.5.y.z extended stable tree 
which can be found at:;a=shortlog;h=refs/heads/linux-3.5.y-queue

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.5.y.z tree, see



From 2953a2000c9bf2a21d1ad6fbbbacbea6d8f949f0 Mon Sep 17 00:00:00 2001
From: Bian Yu <>
Date: Wed, 12 Dec 2012 22:26:58 -0500
Subject: [PATCH] [libata] ahci: Fix lack of command retry after a success
 error handler.

commit 1eaca39a84170b369fe61fb1da3c1e8606859e99 upstream.

It should be a mistake introduced by commit 8d899e70c1b3afff.

qc->flags can't be set AC_ERR_*

Signed-off-by: Bian Yu <>
Signed-off-by: Jeff Garzik <>
Signed-off-by: Herton Ronaldo Krzesinski <>
 drivers/ata/libata-eh.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index 430a248..85fe5bc 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -2057,7 +2057,7 @@  static unsigned int ata_eh_speed_down(struct ata_device *dev,
 static inline int ata_eh_worth_retry(struct ata_queued_cmd *qc)
-	if (qc->flags & AC_ERR_MEDIA)
+	if (qc->err_mask & AC_ERR_MEDIA)
 		return 0;	/* don't retry media errors */
 	if (qc->flags & ATA_QCFLAG_IO)
 		return 1;	/* otherwise retry anything from fs stack */