Patchwork [precise,sru,pull-request] LP#1110605

login
register
mail settings
Submitter Chris J Arges
Date Feb. 4, 2013, 9:20 p.m.
Message ID <1360012812-29577-1-git-send-email-chris.j.arges@canonical.com>
Download mbox
Permalink /patch/218069/
State New
Headers show

Pull-request

git://kernel.ubuntu.com/arges/ubuntu-precise.git lp1110605

Comments

Chris J Arges - Feb. 4, 2013, 9:20 p.m.
The following changes since commit 6f644684eb48787d7bf28658e1517d173b365aa3:

  UBUNTU: (config) Move 9p modules into generic package (2013-01-28 14:05:02 -0800)

are available in the git repository at:

  git://kernel.ubuntu.com/arges/ubuntu-precise.git lp1110605

for you to fetch changes up to 02a7736f85eb35b6336a70e75594db3a800f8cff:

  fsnotify: change locking order (2013-02-04 13:43:34 -0600)

----------------------------------------------------------------
Lino Sanfilippo (10):
      inotify, fanotify: replace fsnotify_put_group() with fsnotify_destroy_group()
      fsnotify: introduce fsnotify_get_group()
      fsnotify: use reference counting for groups
      fsnotify: take groups mark_lock before mark lock
      fanotify: add an extra flag to mark_remove_from_mask that indicates wheather a mark should be destroyed
      fsnotify: use a mutex instead of a spinlock to protect a groups mark list
      fsnotify: pass group to fsnotify_destroy_mark()
      fsnotify: introduce locked versions of fsnotify_add_mark() and fsnotify_remove_mark()
      fsnotify: dont put marks on temporary list when clearing marks by group
      fsnotify: change locking order

Miklos Szeredi (1):
      audit: clean up refcounting in audit-tree

 fs/notify/dnotify/dnotify.c          |    4 +-
 fs/notify/fanotify/fanotify_user.c   |   33 +++++++-----
 fs/notify/group.c                    |   40 +++++++--------
 fs/notify/inode_mark.c               |   14 ++++--
 fs/notify/inotify/inotify_fsnotify.c |    4 +-
 fs/notify/inotify/inotify_user.c     |   11 ++--
 fs/notify/mark.c                     |   91 +++++++++++++++++++---------------
 fs/notify/vfsmount_mark.c            |   14 ++++--
 include/linux/fsnotify_backend.h     |   26 ++++++----
 kernel/audit_tree.c                  |   22 +++++---
 kernel/audit_watch.c                 |    4 +-
 11 files changed, 156 insertions(+), 107 deletions(-)
Luis Henriques - Feb. 4, 2013, 9:31 p.m.
On Mon, Feb 04, 2013 at 03:20:12PM -0600, Chris J Arges wrote:
> The following changes since commit 6f644684eb48787d7bf28658e1517d173b365aa3:
> 
>   UBUNTU: (config) Move 9p modules into generic package (2013-01-28 14:05:02 -0800)
> 
> are available in the git repository at:
> 
>   git://kernel.ubuntu.com/arges/ubuntu-precise.git lp1110605
> 
> for you to fetch changes up to 02a7736f85eb35b6336a70e75594db3a800f8cff:
> 
>   fsnotify: change locking order (2013-02-04 13:43:34 -0600)
> 
> ----------------------------------------------------------------
> Lino Sanfilippo (10):
>       inotify, fanotify: replace fsnotify_put_group() with fsnotify_destroy_group()
>       fsnotify: introduce fsnotify_get_group()
>       fsnotify: use reference counting for groups
>       fsnotify: take groups mark_lock before mark lock
>       fanotify: add an extra flag to mark_remove_from_mask that indicates wheather a mark should be destroyed
>       fsnotify: use a mutex instead of a spinlock to protect a groups mark list
>       fsnotify: pass group to fsnotify_destroy_mark()
>       fsnotify: introduce locked versions of fsnotify_add_mark() and fsnotify_remove_mark()
>       fsnotify: dont put marks on temporary list when clearing marks by group
>       fsnotify: change locking order
> 
> Miklos Szeredi (1):
>       audit: clean up refcounting in audit-tree
> 
>  fs/notify/dnotify/dnotify.c          |    4 +-
>  fs/notify/fanotify/fanotify_user.c   |   33 +++++++-----
>  fs/notify/group.c                    |   40 +++++++--------
>  fs/notify/inode_mark.c               |   14 ++++--
>  fs/notify/inotify/inotify_fsnotify.c |    4 +-
>  fs/notify/inotify/inotify_user.c     |   11 ++--
>  fs/notify/mark.c                     |   91 +++++++++++++++++++---------------
>  fs/notify/vfsmount_mark.c            |   14 ++++--
>  include/linux/fsnotify_backend.h     |   26 ++++++----
>  kernel/audit_tree.c                  |   22 +++++---
>  kernel/audit_watch.c                 |    4 +-
>  11 files changed, 156 insertions(+), 107 deletions(-)
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

These are all clean upstream cherry-picks, which we've been trying for a
while to get into Precise.  Also, we've been testing this patchset of a
while (me and Chris), and this set looks rock solid (yeah, probably I
said the same thing last time...).

Anyway, I wasn't able to reproduce the original bug
(http://bugs.launchpad.net/bugs/922906) nor the nasty regression we had
last time (http://bugs.launchpad.net/bugs/1101666).

Cheers,
--
Luis
Brad Figg - Feb. 5, 2013, 6:58 a.m.
On 02/04/2013 01:20 PM, Chris J Arges wrote:
> The following changes since commit 6f644684eb48787d7bf28658e1517d173b365aa3:
> 
>   UBUNTU: (config) Move 9p modules into generic package (2013-01-28 14:05:02 -0800)
> 
> are available in the git repository at:
> 
>   git://kernel.ubuntu.com/arges/ubuntu-precise.git lp1110605
> 
> for you to fetch changes up to 02a7736f85eb35b6336a70e75594db3a800f8cff:
> 
>   fsnotify: change locking order (2013-02-04 13:43:34 -0600)
> 
> ----------------------------------------------------------------
> Lino Sanfilippo (10):
>       inotify, fanotify: replace fsnotify_put_group() with fsnotify_destroy_group()
>       fsnotify: introduce fsnotify_get_group()
>       fsnotify: use reference counting for groups
>       fsnotify: take groups mark_lock before mark lock
>       fanotify: add an extra flag to mark_remove_from_mask that indicates wheather a mark should be destroyed
>       fsnotify: use a mutex instead of a spinlock to protect a groups mark list
>       fsnotify: pass group to fsnotify_destroy_mark()
>       fsnotify: introduce locked versions of fsnotify_add_mark() and fsnotify_remove_mark()
>       fsnotify: dont put marks on temporary list when clearing marks by group
>       fsnotify: change locking order
> 
> Miklos Szeredi (1):
>       audit: clean up refcounting in audit-tree
> 
>  fs/notify/dnotify/dnotify.c          |    4 +-
>  fs/notify/fanotify/fanotify_user.c   |   33 +++++++-----
>  fs/notify/group.c                    |   40 +++++++--------
>  fs/notify/inode_mark.c               |   14 ++++--
>  fs/notify/inotify/inotify_fsnotify.c |    4 +-
>  fs/notify/inotify/inotify_user.c     |   11 ++--
>  fs/notify/mark.c                     |   91 +++++++++++++++++++---------------
>  fs/notify/vfsmount_mark.c            |   14 ++++--
>  include/linux/fsnotify_backend.h     |   26 ++++++----
>  kernel/audit_tree.c                  |   22 +++++---
>  kernel/audit_watch.c                 |    4 +-
>  11 files changed, 156 insertions(+), 107 deletions(-)
> 

Positive testing by Chris and Luis.
Luis Henriques - Feb. 5, 2013, 1:09 p.m.
Applied to Precise.

On Mon, Feb 04, 2013 at 03:20:12PM -0600, Chris J Arges wrote:
> The following changes since commit 6f644684eb48787d7bf28658e1517d173b365aa3:
> 
>   UBUNTU: (config) Move 9p modules into generic package (2013-01-28 14:05:02 -0800)
> 
> are available in the git repository at:
> 
>   git://kernel.ubuntu.com/arges/ubuntu-precise.git lp1110605
> 
> for you to fetch changes up to 02a7736f85eb35b6336a70e75594db3a800f8cff:
> 
>   fsnotify: change locking order (2013-02-04 13:43:34 -0600)
> 
> ----------------------------------------------------------------
> Lino Sanfilippo (10):
>       inotify, fanotify: replace fsnotify_put_group() with fsnotify_destroy_group()
>       fsnotify: introduce fsnotify_get_group()
>       fsnotify: use reference counting for groups
>       fsnotify: take groups mark_lock before mark lock
>       fanotify: add an extra flag to mark_remove_from_mask that indicates wheather a mark should be destroyed
>       fsnotify: use a mutex instead of a spinlock to protect a groups mark list
>       fsnotify: pass group to fsnotify_destroy_mark()
>       fsnotify: introduce locked versions of fsnotify_add_mark() and fsnotify_remove_mark()
>       fsnotify: dont put marks on temporary list when clearing marks by group
>       fsnotify: change locking order
> 
> Miklos Szeredi (1):
>       audit: clean up refcounting in audit-tree
> 
>  fs/notify/dnotify/dnotify.c          |    4 +-
>  fs/notify/fanotify/fanotify_user.c   |   33 +++++++-----
>  fs/notify/group.c                    |   40 +++++++--------
>  fs/notify/inode_mark.c               |   14 ++++--
>  fs/notify/inotify/inotify_fsnotify.c |    4 +-
>  fs/notify/inotify/inotify_user.c     |   11 ++--
>  fs/notify/mark.c                     |   91 +++++++++++++++++++---------------
>  fs/notify/vfsmount_mark.c            |   14 ++++--
>  include/linux/fsnotify_backend.h     |   26 ++++++----
>  kernel/audit_tree.c                  |   22 +++++---
>  kernel/audit_watch.c                 |    4 +-
>  11 files changed, 156 insertions(+), 107 deletions(-)
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Cheers,
--
Luis