Patchwork sunrpc: fix rdma dependencies

login
register
mail settings
Submitter Randy Dunlap
Date Feb. 3, 2009, 10:13 p.m.
Message ID <4988C17B.1030902@oracle.com>
Download mbox | patch
Permalink /patch/21800/
State Accepted
Delegated to: David Miller
Headers show

Comments

Randy Dunlap - Feb. 3, 2009, 10:13 p.m.
Andrew Morton wrote:
> This patch was dropped because other changes were merged, which wrecked this patch.

The kconfig just moved from one file to another one.  The problem is still there.

---
From: Randy Dunlap <randy.dunlap@oracle.com>

Fix sunrpc/rdma build dependencies.
Survives 12 build combinations of INET, IPV6, SUNRPC,
INFINIBAND, and INFINIBAND_ADDR_TRANS.

ERROR: "rdma_destroy_id" [net/sunrpc/xprtrdma/xprtrdma.ko] undefined!
ERROR: "rdma_connect" [net/sunrpc/xprtrdma/xprtrdma.ko] undefined!
ERROR: "rdma_destroy_qp" [net/sunrpc/xprtrdma/xprtrdma.ko] undefined!
ERROR: "rdma_create_id" [net/sunrpc/xprtrdma/xprtrdma.ko] undefined!
ERROR: "rdma_create_qp" [net/sunrpc/xprtrdma/xprtrdma.ko] undefined!
ERROR: "rdma_resolve_route" [net/sunrpc/xprtrdma/xprtrdma.ko] undefined!
ERROR: "rdma_disconnect" [net/sunrpc/xprtrdma/xprtrdma.ko] undefined!
ERROR: "rdma_resolve_addr" [net/sunrpc/xprtrdma/xprtrdma.ko] undefined!
ERROR: "rdma_accept" [net/sunrpc/xprtrdma/svcrdma.ko] undefined!
ERROR: "rdma_destroy_id" [net/sunrpc/xprtrdma/svcrdma.ko] undefined!
ERROR: "rdma_listen" [net/sunrpc/xprtrdma/svcrdma.ko] undefined!
ERROR: "rdma_create_id" [net/sunrpc/xprtrdma/svcrdma.ko] undefined!
ERROR: "rdma_create_qp" [net/sunrpc/xprtrdma/svcrdma.ko] undefined!
ERROR: "rdma_bind_addr" [net/sunrpc/xprtrdma/svcrdma.ko] undefined!
ERROR: "rdma_disconnect" [net/sunrpc/xprtrdma/svcrdma.ko] undefined!

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
cc:	J. Bruce Fields <bfields@fieldses.org>
cc:	Neil Brown <neilb@suse.de>
cc:	Roland Dreier <rolandd@cisco.com>
cc:	Dave Miller <davem@davemloft.net>
---
 net/sunrpc/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Feb. 3, 2009, 11:20 p.m.
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Tue, 03 Feb 2009 14:13:15 -0800

> Fix sunrpc/rdma build dependencies.
> Survives 12 build combinations of INET, IPV6, SUNRPC,
> INFINIBAND, and INFINIBAND_ADDR_TRANS.
 ...
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>

Applied, thanks Randy.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- mmotm-2009-0202-1712.orig/net/sunrpc/Kconfig
+++ mmotm-2009-0202-1712/net/sunrpc/Kconfig
@@ -6,7 +6,7 @@  config SUNRPC_GSS
 
 config SUNRPC_XPRT_RDMA
 	tristate
-	depends on SUNRPC && INFINIBAND && EXPERIMENTAL
+	depends on SUNRPC && INFINIBAND && INFINIBAND_ADDR_TRANS && EXPERIMENTAL
 	default SUNRPC && INFINIBAND
 	help
 	  This option allows the NFS client and server to support