From patchwork Tue Feb 3 21:27:27 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: stephen hemminger X-Patchwork-Id: 21797 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id E3B97DDF33 for ; Wed, 4 Feb 2009 08:29:37 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751524AbZBCV3d (ORCPT ); Tue, 3 Feb 2009 16:29:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751572AbZBCV3b (ORCPT ); Tue, 3 Feb 2009 16:29:31 -0500 Received: from suva.vyatta.com ([76.74.103.44]:48592 "EHLO suva.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751598AbZBCV3Z (ORCPT ); Tue, 3 Feb 2009 16:29:25 -0500 Received: from suva.vyatta.com (suva [127.0.0.1]) by suva.vyatta.com (8.13.7/8.13.7) with ESMTP id n13LTNC2013330; Tue, 3 Feb 2009 13:29:23 -0800 Received: (from shemminger@localhost) by suva.vyatta.com (8.13.7/8.13.7/Submit) id n13LTNjQ013329; Tue, 3 Feb 2009 13:29:23 -0800 Message-Id: <20090203212755.892910982@vyatta.com> References: <20090203212726.983207890@vyatta.com> User-Agent: quilt/0.46-1 Date: Tue, 03 Feb 2009 13:27:27 -0800 From: Stephen Hemminger To: David Miller Cc: netdev@vger.kernel.org Subject: [PATCH 1/4] sky2: remove unneede workaround Content-Disposition: inline; filename=sky2-tim-opt.patch Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This workaround is not needed. It was inherited from sk98lin driver but only applies to an early development version of the chip that is not supported by sky2. The workaround required an unnecessary pci read which hurts performance Signed-off-by: Stephen Hemminger --- a/drivers/net/sky2.c 2009-01-26 17:23:25.869792360 -0800 +++ b/drivers/net/sky2.c 2009-01-27 09:43:21.770394724 -0800 @@ -2687,13 +2687,6 @@ static int sky2_poll(struct napi_struct goto done; } - /* Bug/Errata workaround? - * Need to kick the TX irq moderation timer. - */ - if (sky2_read8(hw, STAT_TX_TIMER_CTRL) == TIM_START) { - sky2_write8(hw, STAT_TX_TIMER_CTRL, TIM_STOP); - sky2_write8(hw, STAT_TX_TIMER_CTRL, TIM_START); - } napi_complete(napi); sky2_read32(hw, B0_Y2_SP_LISR); done: