Patchwork [1/4] sky2: remove unneede workaround

login
register
mail settings
Submitter stephen hemminger
Date Feb. 3, 2009, 9:27 p.m.
Message ID <20090203212755.892910982@vyatta.com>
Download mbox | patch
Permalink /patch/21797/
State Accepted
Delegated to: David Miller
Headers show

Comments

stephen hemminger - Feb. 3, 2009, 9:27 p.m.
This workaround is not needed. It was inherited from sk98lin driver but only
applies to an early development version of the chip that is not supported
by sky2.  The workaround required an unnecessary pci read which hurts performance

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

Patch

--- a/drivers/net/sky2.c	2009-01-26 17:23:25.869792360 -0800
+++ b/drivers/net/sky2.c	2009-01-27 09:43:21.770394724 -0800
@@ -2687,13 +2687,6 @@  static int sky2_poll(struct napi_struct 
 			goto done;
 	}
 
-	/* Bug/Errata workaround?
-	 * Need to kick the TX irq moderation timer.
-	 */
-	if (sky2_read8(hw, STAT_TX_TIMER_CTRL) == TIM_START) {
-		sky2_write8(hw, STAT_TX_TIMER_CTRL, TIM_STOP);
-		sky2_write8(hw, STAT_TX_TIMER_CTRL, TIM_START);
-	}
 	napi_complete(napi);
 	sky2_read32(hw, B0_Y2_SP_LISR);
 done: